I get the following error code when choosing 'node/foo/submission/bar':

* Notice: Undefined index: 2 in _webform_client_form_rule_check() (Zeile 1837 von /var/www/drupal7/sites/all/modules/webform/webform.module).
* Notice: Undefined index: 2 in _webform_client_form_rule_check() (Zeile 1837 von /var/www/drupal7/sites/all/modules/webform/webform.module).

Thank you for fixing this! Great, essential module!!!

CommentFileSizeAuthor
#1 webform_undefined_index-d7.patch543 bytesquicksketch

Comments

quicksketch’s picture

quicksketch
he/him
commented
Priority: Normal » Minor
Status: Active » Fixed
StatusFileSize
new webform_undefined_index-d7.patch543 bytes

Thanks for the report. This patch should correct the problem. This is just a "notice" error, which means it doesn't actually have any actual effect on you site other than the error message. Committed this patch to both 3.x branches.

Blooniverse’s picture

Blooniverse commented

... oh, another isset() check/validation was lacking -- I should have known/recognized myself. Theese wrongly formulated respectively forgotten checks seem to be everywhere since Drupal7! Next time I am going to patch myself. Thanks for the effort, nevertheless!

quicksketch’s picture

quicksketch
he/him
commented

These wrongly formulated respectively forgotten checks seem to be everywhere since Drupal7!

That's just because Drupal 7 explicitly defaults to showing all notices, when in Drupal 6 they were omitted or followed the global settings in php.ini (which also hides them by default).

Blooniverse’s picture

Blooniverse commented

... very well, then we will get the best code ever now :)
Nonetheless, such basic issues should actually stand out anyway (with or without certain error display settings), I have to say. Or not? I mean: I don't consider myself as a developer/programmer at first place, but my self made CMS 2001 and my integral business software 2006 didn't resp. don't have such fundamental flaws. That just should not happen. It just cannot work like this.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.