When setting up selectors for an available font (admin/appearance/fontyourface/edit/[id]) the button which saves the form reads "Edit font."

On this form, one is not editing the font, one is saving the selectors and whether they are active or not.

The button should read something like "Save selector."

Comments

sreynen’s picture

sreynen commented
Status: Active » Needs work

You're right that one is not editing the font, but one isn't necessarily saving a selector either. You could be just enabling or disabling the font. Or, you could be only changing the selector without changing the enabled status. So it should probably be a phrase that includes all of that.

Other considerations: the local font submodule from #930066: Make it possible to include local installed fonts (local on the webserver) currently adds a "Delete font" button, which is similarly misleading (you're not really deleting the font itself, just the database record of it) and #1037712: Add ability to edit tags on font edit screen will make tags another thing you could be editing on that screen.

So I think the text should be something more general to indicate you're changing various attributes of a font, something like "Save font attributes." I'm sure there's a better phrase than that, but I can't think of it right now.

c4rl’s picture

c4rl commented

So it should probably be a phrase that includes all of that.

Items like this are often an exercise in language. What are we saving? What's the noun and what's the verb? Would something like "Save ruleset" be valid?

Then again, something like "Save changes" is boilerplate, but works.

sreynen’s picture

sreynen commented
Status: Needs work » Fixed

I went with "Save font settings." Committed to both D7 and D6 branches.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.