When viewing/update the shopping cart, it seems like (even though the remove button IS right there also) that when updating quantity to 0 (zero), the update cart button should then fire off and remove the item from the cart, and not throw an error.

CommentFileSizeAuthor
#5 1080342.zero_qty.patch2.77 KBrszrama
order-quantity-zero.png57.63 KBhimerus

Comments

torgospizza’s picture

torgospizza
he/him
Primary language English
Location Portland, OR
commented

I agree. This is how Ubercart behaves, and how other shopping systems like Amazon behave. Plus, it's a faster way of deleting the entire cart - setting every qty to 0, rather than hitting every Remove button.

My two cents.

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented

Here is the change to allow 0 qty for deleting line items

Not really sure what info is needed for the commit:

Repo: git.drupal.org:sandbox/pcambra/1081200.git
Branch: 1080342
Diff: http://drupalcode.org/sandbox/pcambra/1081200.git/commitdiff/01acdd66348...

himerus’s picture

himerus commented
Status: Active » Reviewed & tested by the community

This works like a champ for me... everything works as expected.
Remove button (per line item) functionality remains unchanged
Setting all or individual items to 0 quantity and updating cart removes the appropriate line items as expected.

Thank you for this fix! Marking RTBC. Please feel free to mark back to review if you feel it needs more testing. Normally I don't mark RTBC if I'm the first/only tester, but this one seems like a pretty simple patch.

Great addition.

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented

Oh, I forgot to say that I didn't change the order management page for qty = 0 as we have already a checkbox for removing there.

rszrama’s picture

rszrama commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 1080342.zero_qty.patch2.77 KB

Gonna see if I can run this by the test bot. (Trying to get it working again.)

rszrama’s picture

rszrama commented
Status: Needs review » Fixed

I forgot to update this when we discovered the test bot doesn't support projects with dependencies. : P

Committed and we'll try again with the test bot once we can actually use it.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.