Will this module be ported to Drupal 7

Comments

flevour’s picture

I have not enough time to take care of the porting at the moment, is anyone willing to take care of it?
Thanks for your interest,
Francesco

Rob C’s picture

Status: Active » Needs work

I have started working on a port. The logic works, adding a destination in the db works. I already had a working version, but i decided to redo the admin page and i have even more ideas. (custom contextual link at the top right of every form for example, so you can easy-add a destination to any form.) and more!

https://github.com/ClusterFCK/customdestination

Hope i have a working version (including admin page) somewhere this week(end).

Rob C’s picture

Status: Needs work » Needs review

Did some more work on it today, separated the admin interface into a new module. You can enable this module only when you need to make changes, similar to like views operates. Enabling the module also works well with the contextual form edit button that i'm working on. (else that also needed to run for every hook_form_alter(). Lil bit out of the box on the admin interface, still needs work, but you can: list, add, edit (validate needs work), delete, delete multiple, edit module settings. What really still needs work: contextual link. (didn't even include the contextual link yet, still in very much alpha stage). But every thing else should work from what i can tell now, and thus, needs serious testing. It is mostly working now.
UPDATE: fixed some other small issues. (form operations) and some other minor tweaks.

Shai’s picture

Awesome module. Thanks so much for porting it to 7.

The module works. However, I'm getting the following error messages:

Notice: Undefined index: #attributes in customdestination_form_alter() (line 27 of sites/all/modules/customdestination/customdestination.module).
Warning: in_array() [function.in-array]: Wrong datatype for second argument in customdestination_form_alter() (line 27 of sites/all/modules/customdestination/customdestination.module).

Also, the choice on the admin page to display the form name doesn't work. I don't need that functionality. Especially since the "Add custom destination" link shows up on forms. (NOTE that my site is all https site, I use uc_ssl to handle that.)

I think you'd get more feedback if you posted the module on the module page as a dev version.

Again, thanks for the great module.

Shai Gluskin

Rob C’s picture

Assigned: Unassigned » Rob C
Status: Needs review » Needs work

Shai thank you for the kind reaction.

The D7 port still needs work, it's close to getting on a level to be more correct from a form api view.

I became a co-maintainer for this module a couple of days ago, but my time is very limited at the moment due to personal stuff and other modules i try to get to D7. (media_pbs/media_ustream(and ustream live). But it is 100% on my TODO list, so you can expect a code move to d.o. git repo + update in a couple of weeks tops. (got bigger fish to fry at the moment)

I'll take a look at your issue soon, i can already guess why this is, but i didn't do a lot of coding for this release last weeks. I am working on a new version, that supports more features, like: (custom) messages, destinations per form result type (normal/warning/error), exclude/include users/groups and more. But that's long from release-ready. (maybe a future 7.x-2.x will come out of this) Keep an eye on the project page, i'll also update this issue ones i created an initial D7 branch.

Thanks again!

Shai’s picture

ClusterFCK,

Thanks, good stuff in the works.

I've now set my notifications to receive all activity regarding Custom (Form) Destination.

Shai

nancydru’s picture

You need to add an ID or CLASS to the div with the links in it. There are pages on which I can't show those links and there is no way to hide the DIV.

Rob C’s picture

Assigned: Rob C » Unassigned
Issue summary: View changes