Either the CSS is wrong (selectors) or the HTML is wrong - I assume its the selectors, but when I enable this theme the layout is borked - meaning the sidebars are not positioned correctly and the main content column is full width (960px?). I don't have time to debug this but it makes using this theme basically impossible.
I set up a testing site for all the HTML5 D7 starter themes and am posting issues against each theme as they arise: http://adaptivethemes.com/drupal-html5-themes/
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | layout-1080630-3.patch | 610 bytes | tim.plunkett |
| #1 | layout-fix-1080630.patch | 1.67 KB | RockSoup |
Comments
Comment #1
RockSoup commentedAdding a class to a container in page tpl and some CSS to fix layout issue. CSS in layout file was referring to classes that did not exist.
Comment #2
tim.plunkett#content should be #content-wrapper. Would be nice if we could use [role=main] as a selector, but I understand why we can't.
Comment #3
tim.plunkettMost of this was obsoleted by #1036524: Use Stark layout css to get started.
But region IDs were misnamed, using underscores instead of hyphens.
Comment #4
mason@thecodingdesigner.com commentedlooks good. lets continue to keep the preprocessors to a minimum. Stuff that keeps the tpl's clean is good.
Comment #5
tim.plunkettCommushed to 7.x-2.x: http://drupalcode.org/project/html5_base.git/commit/ff5ce9b