Closed (fixed)
Project:
Commerce Core
Version:
7.x-1.x-dev
Component:
Rules integration
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
4 Mar 2011 at 01:04 UTC
Updated:
6 Apr 2011 at 01:41 UTC
Okay... The screenshots tell it all.
My use case here was to first, just get an order status updated to something besides pending... then work on the conditions to match before updating status to complete (based on a custom payment method for free products)
Not sure where/what is causing this, I will continue to dig in a bit.
| Comment | File | Size | Author |
|---|---|---|---|
| commerce-order-statuses-issue.png | 43.61 KB | himerus | |
| commerce-checkout-active-disabled-rules.png | 111.44 KB | himerus | |
| commerce-order-status-cloned-modified-status-value.png | 65.23 KB | himerus | |
| commerce-order-status-default.png | 64.6 KB | himerus |
Comments
Comment #1
himerus commentedoops.. links in the UL are broken.. refer to attachments below.
Comment #2
himerus commentedThis actually seems to be happening by an EXACT duplicate of the default rule in code:
I've only changed the label text, the order_state value, and the index for the $rules array.
So in testing, this is not working via creating the rule in the interface OR in code.
Not quite sure where this issue should be (Rules or Commerce)
Comment #3
pcambraOk, we hit two problems here, one is that the order state for completed misdefine the default order status, thus the labels and defaults get messed up, I'm attaching a patch to solve this.
In the other hand, rules doesn't seem to be respecting the weight for default rules that doesn't define weight and it is executing all them at the end, I've opened a issue in rules queue for this #1083908: Action weight is not considered for default rules with weight 0, but a quick workaround could be to just open & save the default rule, then the weights work fine.
For the patch:
Repo: git.drupal.org:sandbox/pcambra/1081200.git
Branch: 1080764
Diff: http://drupalcode.org/sandbox/pcambra/1081200.git/commitdiff/17d60fa8e8b...
Comment #4
rszrama commentedCommitted. That errant whitespace adjustment you made in commerce_order.module caused a merge conflict, though, because I removed that TODO before I committed this patch. It wasn't a problem at all, but it'd be good to keep those tweaks out of general patches. : )