Express It

I did a search and can't find your project sandbox.

Hello, manikan. You need to create a sandbox project, and provide the link here.

A general question I have is that this module seems fairly similar to the concept of voting by emotions in the rate module I wonder if you could explain how you see them as being different and why Express It is better.

I've created two critical issues related to security:
#1129504: XSS via expression name
#1129488: expressit ajax function vulnerable to CSRF (Cross Site Request Forgery) and access bypass

Those must be fixed before the project can be approved.

There's also a few code style issues:
#1129494: Various code style issues

Those should be fixed before the project can be approved.

I spent 15 minutes reviewing the code and did not test out the functionality.

The ImageProcess code is copied from http://www.white-hat-web-design.co.uk/articles/php-image-resizing.php This is not really appropriate with Drupal's licensing policy since you could potentially tell people to download the file from there.

However, I think it's OK to include this code as long as you give credit in the README.txt

Also, you should remove the LICENSE.txt from git. That file is added automatically for all projects.

All project applications have the same priority.

Again, as sreynen said, all project applications have the same priority so please leave it on "normal".

Please do not change the priority. If you need it reviewed quickly the best solution is to respond in a timely manner to suggests (it's been over a month since my comment with no response from you).

It seems you did not actually push the changes to drupal.org so marking needs work.

Updating priority according to the new project application priority guidelines. The application's priority should be set back to normal once a reviewer responds to your application and the application review process has continued.

Hello again!

You can remove // $Id$ and similar tags, they are no longer needed with git.

Please review the drupal coding standards at http://drupal.org/coding-standards it will help us review your module and help facilitate collaboration.

Also, please run your module through the Coder module (http://drupal.org/project/coder) on minor (most)

Some of the coding standards issues:

Conditionals and functions should have opening brackets on the same line as the statement

Indentation should be two spaces, no tabs

drupal_uninstall_schema('expression'); This should only need to be the name of your module! You shouldn't Be installing each table separately. http://api.drupal.org/api/drupal/includes--common.inc/function/drupal_in...
Does this even work?

Oh I see,
function expression_schema() This should be namespaced with your module name and you should be installing you module's schema, this is not correct. It's likely that drupal_uninstall_schema('user_expression') is not even doing anything at all.

8 ; Information added by drupal.org packaging script on 2010-06-02 you can remove this, as well as the package in your .info file, unless there is an established Expression package or your module is a package itself.

Please remove LICENSE.txt, that will be added Automatically when your project is promoted.

18 variable_set('express_node_types', 'page'); you should not need to set variables in hook install, this is why we have defaults.

Also, looking at this variable name and some function names it seems like there is some inconsistency in namespacing variables and functions. I see express, express_it, and expression as well as other functions that are not namespaced at all ( 156 function add_express($form_state, $express = NULL) {) This is important because of the number of various modules any one site could have installed. We just want to minimize potential conflicts. Some function names are short and not namespaced and could potentially cause conflicts.

Lastly, what is the license on ImageProcess.php?

No activity in several months. Reopen and set the status to "needs review" if you are still pursuing this application.