A minor annoyance - we ignore .svn dirs but not .git dirs. That makes a lot of noise.

CommentFileSizeAuthor
#3 drush-1081524.patch754 bytesjonhattan

Comments

anarcat’s picture

Project: Provision » Drush
Component: Code » Core Commands

This is actually a drush issue - the exclude patterns are generated from the "version_control" engines and there's no such engine for git..

This is in commands/core/rsync.core.inc:

function drush_core_call_rsync($source, $destination, $additional_options = array(), $include_settings_is_default = TRUE, $live_output = TRUE) { files.
  $options = '';
  $vcs_files = drush_version_control_reserved_files();
  foreach ($vcs_files as $file) {
    $options .= ' --exclude="'.$file.'"';

I guess that we would need to create a engine for git but this seems rather overkill for just an exclude pattern.

moshe weitzman’s picture

Assigned: Unassigned » jonhattan

Seems like we should ignore those somehow.

jonhattan’s picture

Status: Active » Needs review
StatusFileSize
new754 bytes

When drush_version_control_reserved_files() was introduced the plan was to have #797190: Git version control engine for --gitsync and more.

Patch attached hardcode support for git and mercurial (just in case) in drush_version_control_reserved_files().

moshe weitzman’s picture

Status: Needs review » Reviewed & tested by the community

Looks good. Thanks.

jonhattan’s picture

Status: Reviewed & tested by the community » Fixed

committed.

jonhattan’s picture

Version: » All-versions-4.x-dev
Assigned: jonhattan » msonnabaum
Status: Fixed » Patch (to be ported)
msonnabaum’s picture

Status: Patch (to be ported) » Fixed

Backported.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.