D7 version of onbeforeunload [#1081552]

Attached is a quick patch to update this to D7. There are only two changes in the JS:

Encapsulated the JS to avoid conflicts for jQuery $ (see http://drupal.org/update/modules/6/7#javascript_compatibility)
Changing the Drupal.behavior definition to an object holding an "attach" function (see http://drupal.org/update/modules/6/7#drupal_behaviors)

The rest is indenting as a result of the "attach" change. Please note that I didn't touch the example module. If the formatting of this patch works OK, I can add that in too. Thanks!

Comment	File	Size	Author
	onbeforeunload_d7upgrade_v01.patch	2.54 KB	seanbfuller

Comments

Comment #1

seanbfuller commented 4 March 2011 at 17:25

Status:

Active

» Needs review

Sorry, forgot to mark as needs review.

Comment #2

seanbfuller commented 2 May 2011 at 18:15

I did some more digging into this to resolve some issues regarding the overlay in D7 (see #950736: DirtyForm Port to D7). I couldn't find a consistent way to catch any kind of onunload event for the overlay's iframe. I was able to get close by trying to bind the hashchange.drupal-overlay event, but there was no elegant way to stop overlay from processing the page change. I played around with adding a check in Drupal.overlay.redirect to see if Drupal.onBeforeUnload exists and then adding some sort of call confirm call, but that is obviously a hack to core and also probably not the best way to go about it.

Unless someone with a better understanding of the overlay module has a better idea, it seems that a patch to overlay allowing other modules to register a check that stops overlay from changing the page would be needed.

While looking into this, I also found #655388: Many ways to lose data on form input in the overlay, which mentions dirtyforms and different options for dealing with things this module might be used for.

As it stands, this patch and dirtyforms seems to be working for D7... unless you have the overlay enabled. Not sure of the best next step.