Testing out the Soundmanager2 player on 3.x

(This is also on a large site that I am converting from 5.x to 6.x so am not going to attempt to map out the mess of other possible conflicts... but seemed like I should mention it... so if it works for everyone else, pls disregard :)

I've noticed that in the SM2 settings (admin/settings/swftools/soundmanager2)
my choice of player has an odd effect

everything is fine when I choose and save either: (see first image)
UI360 - small
UI360 - with visualization

but when I choose and save either of these as a player:
Playable mp3 links
Small button player

The file handling page (admin/settings/swftools/handling)
looses it's ability to open it's subsections. (see second image)

to access the file handling page I can go and change back to the UI360
but obviously not ideal.

fyi

CommentFileSizeAuthor
#2 swftools-1081600-2.patch1.01 KBjoelstein
screenshot with no active links to subsections15.25 KBridefree
screen shot with active links to subsections19.48 KBridefree

Comments

Stuart Greenfield’s picture

Stuart Greenfield commented
Status: Active » Postponed

SoundManager 2 support is largely experimental at the moment. It needs quite a bit of work, so for now I'm going to postpone further work and focus on getting a function 6.x-3.x release out (with SM2 as it is).

However, I will come back to this, so if you find other issues, or find solutions to any of them, please continue to post so I can re-open them.

Thanks.

joelstein’s picture

joelstein commented
Title: Soundmanager2 - weird bug with file handling page and player choice » Javascript bug when choosing other Soundmanager2 player types
Version: 6.x-3.0-beta4 » 6.x-3.0-beta5
Status: Postponed » Needs review
StatusFileSize
new swftools-1081600-2.patch1.01 KB

This is caused by a Javascript bug which only appears if you choose a player other than the UI360 players. Here's what I see in my Javascript console:

Uncaught ReferenceError: threeSixtyPlayer is not defined.

The culprit is line 12 of swftools/soundmanager2/swftools_soundmanager2.js, which tries to access the threeSixtyPlayer variable, though it doesn't exist in this context. By simply moving that line within the following "if" statement, the error goes away. All players seem to work with this change.

The attached patch works for me.