Hi,
First I would like to say this module is awesome. I've enjoyed reading it and have enjoyed using it. The one issue I came across was the context_reaction_block_all_regions variable used in the block reaction class. I wasn't a huge fan of it being a global variable and I felt it would be useful as a $_SESSION or $_COOKIE variable so on a per user basis they could turn on and off this functionality. I wrote a small module that makes use of some hook alter type functions that accomplishes this. My only issue is that I had to copy the block reactions plugin into my module then slightly alter it. Would this be useful functionality in context core or should I roll out my own module? Either way I would be willing to do the coding. Input would be very much appreciated.
Thanks,
Trevor
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | show-all-regions-1081854.patch | 6.93 KB | tmckeown |
| #1 | show-all-regions-feature-task-1081854.patch | 6.81 KB | tmckeown |
Comments
Comment #1
tmckeown commentedJust rolled a patch against 6.x-3.x. If this goes well I can also roll a patch against the 7.x-3.x branch.
Thanks,
Trevor
A patch sponsored by The Collegeboard. Check us out at http://www.collegeboard.org
Comment #2
tmckeown commentedComment #3
tmckeown commentedComment #4
tmckeown commentedComment #5
tmckeown commentedrerolled a patch. Fixed an error, added comments, removed no new lines, and removed inline style.
Comment #6
tmckeown commentedCreated a module as well.