Add caching of conflict checking [#1081892]

We use resource_conflict in code to build schedules, so it can be called thousands of times in a loop.

The patch to follow will add cacheing to avoid repetitive SQL queries.

Comment	File	Size	Author
#3	resource_conflict-cache-1081892-1.patch	6.64 KB	glennpratt

Comments

Comment #1

deviantintegral commented 4 July 2011 at 13:33

This sounds like a good idea. I'm not sure basic caching would provide much of a performance improvement over the regular query cache. Are you looking at static caching, or storing cached objects? What would they be keyed by?

If it makes writing a patch easier, I'm completely OK with requiring ctools so we can use ctools_static().

Comment #2

deviantintegral commented 4 July 2011 at 13:34

Title:

Add cacheing

» Add caching of conflict checking

Comment #3

glennpratt commented 6 July 2011 at 03:09

Status	File	Size
new	resource_conflict-cache-1081892-1.patch	6.64 KB

Whoops! Guess I wasn't paying attention, forgot to attach a patch.

I haven't seen any bugs with our scheduler since I wrote this, the cacheing is aggressive because we we're getting killed by SQL load. It may need to be toned down a bit.

Is ctools_static like D7 drupal_static? If so, that will work great! :)