Hi,

Please support cck role reference, thanks for creating a nice module

joseph

CommentFileSizeAuthor
#3 2011-04-03_1082124-3.patch1.09 KBarhak

Comments

arhak’s picture

do you refer to rolereference?

jmolinas’s picture

yes

arhak’s picture

Project: Comment driven » Driven API
Status: Active » Needs review
StatusFileSize
new1.09 KB

it seems pretty similar to userreference & nodereference (if not a total copycat)
nevertheless it deserves throughout testing (which I'm not doing)
to ensure it properly behaves for every possible combination,
i.e. single/multiple values, limited/unlimited values, required/non-required, and all that for each of its widgets

attached patch merely enables it for driven_diff, without any special consideration,
i.e. it just removes the "unsupported field type" constraint and hopes for the best

BTW: I noticed that having a single value, not required, select dropdown widget, doesn't leave an option to select "none"

jmolinas’s picture

ye it behaves like just other cck reference module

thank you very much

arhak’s picture

watch out, it doesn't mean they are the same.
nodereference does allow "None" option when the field is not required,
so there are differences between them
and thus, proper tests are due

jmolinas’s picture

Status: Needs review » Fixed

I've tested it, it work no error so far

arhak’s picture

Status: Fixed » Needs review

@#6
ok, but it hasn't been committed yet
also, it would require further testing (beyond your particular cases, as stated in #3)