Drupal 7 port

Here is a patch to port the module to D7.

I haven't tested lightbox support, but it does not seem to have a D7 version available right now anyway (and when it does, I presume uc_tc should just work, if lightbox works as before).

Dev-Version of Lightbox2 from #670820: Port Lightbox2 to Drupal 7 in comment 166 doesn't work with your port of uc_tc.

The string '?format=lightbox2' was appended to the Terms and conditions path but the lightbox doesn't pop up and the site was just loading without lightbox support.

Hmm, there is a bug in how the "rel" attribute is handled. It ouputs an incorrect attribute. Seems to be related to how l() handles options. I checked the docs and could not find what the code is doing wrong.

Ubercart 3 seems to prefer Coloubox instead of Lightbox. Is anybody currently working on porting this module to Drupal 7?

http://drupal.org/project/ubercart
http://drupal.org/project/colorbox

subscribed

This would have more effect it whoever has permissions would create a 7.x-1.x-dev branch hence people will test & review the patch and afterwards would be committed.

The current existing patch doesn't apply neither stable version not dev version.

Thanks in advance.

I used webform & Iframe to do this - its faster that waiting for someone to port the module

@stevieb: What do you mean? Did you find a solution to bring terms and conditions into ubercart 7.x-xx with webform and Iframe? How? Or do you include your old D6 Ubercart shop via Iframe?

@steveib @majorbenks: Do you have a solution for the T&C in D7 that you are happy about?

It would be really great to get a 7.x-1.x branch of this module going.

I have taken the latest version of the 6.x-1.x dev branch and applied the patch in #1 manually.

I also did a small tweak where if lightbox isn't being used, the T&C link opens in a new window. I am not using lightbox on my website so cannot confirm if this is working (I suspect it isn't) but what I have done would be a great place to start.

Module attached.

Thanks jarrodirwin for the update.

I sent a message to the module maintainer to request commit access to the module.

Thanks. I've gone for Webform + Webform Validation + Webform Checkout Pane. The webform is just a single option choice (yes/no), validation requires it to be yes, and this is made into an Ubercart checkout pane. It seems to work, though it required minor CSS tweaking to look good. What I like about this combination is that I get a record, via webform "results", of the acceptance of T&Cs. Being separate from the cart system, in a way, it can be considered as an audit, if need be.

Naturally, it would be great to have this module in UC, so it is not necessary to go this long way around. Thanks for submitting it, will have a look at the next rev of our site.

@bgm, you have commit access now.

Let you close this issue... see if you can confirm lightbox2 is still working as it was on D6 though.

Thanks hanoii !

I created a 7.x-2.x branch (and dev release), and included jarrodirwin's changes for lightbox2 (I only did a small change in the ID of the link to be uc_tc_checkbox, not tc_checkbox).

Please test

@ MPeli : if you'd like support of the "colorbox" module, please open a separate issue. If possible, describe what kind of code would be necessary to support it (i.e. probably requires some sort of tag in the link or html so that colorbox can work).

why 2.x? I would have made more sense to continue 1.x.. it's not a big deal anyway.. but... just wondering.

Hmm, I had not given it much thought. Does it have an impact?

Although eventually if new features are added to the 7.x version, I don't personally plan on backporting them (ex: colorbox support).

This has been accomplished so far with a functional -dev version (anyway tere is no 'Stable' version at the moment).

So there is no more aim to get a D7 version but to fix bugs in the newly ported version :-)