database.mysql and database.pgsql do not insert all of the required modules (filter, system, user, watchdog) into the sytem table. This still works, as module_load() looks for them in modules/, but it should probably be fixed. The attached patch adds them.

CommentFileSizeAuthor
required_modules.patch3.1 KBjhriggs

Comments

jhriggs’s picture

jhriggs commented

It's a patch, Stupid. ;)

dries’s picture

dries commented

I can't remember why we insert these at installation time. As you say, everything works without having to insert them. Maybe the other/existing insert statements are cruft?

jhriggs’s picture

jhriggs commented

It inserts them so that a default, baseline set of modules are enabled on a fresh install (block, comment, help, node, etc.). This is reasonable and probably shouldn't be removed, but I think the required modules should definitely be in there also. This was discovered when the multisite patch broke (because it couldn't find the required modules).

Steven’s picture

Steven commented

What Dries means is to remove the system table entries for required modules altogether. The modules are hardcoded to be included anyway.

moshe weitzman’s picture

moshe weitzman commented

It sounds like this patch is not needed. please reset status if i'm wrong

jhriggs’s picture

jhriggs commented

This was rolled into the multisites patch which required it.

Anonymous’s picture

(not verified) commented