Any plans about porting?

Queue now a part of core so seems this should simplify the module.

Comments

basicmagic.net’s picture

subscribe

kehan’s picture

subscribing too

jdleonard’s picture

subscribing

ktleow’s picture

Comment Notify brings me here for scheduling emails.

Looking forward for D7 port.

BeaPower’s picture

sub

shadowdknight’s picture

any temporary solution until we wait for the port?

Michael Zetterberg fd. Lopez’s picture

+1

Michael Zetterberg fd. Lopez’s picture

I've been giving a try at a patch for this issue. Good news is that #800434: drupal_mail, allow hook_mail_alter implementation to cancel mail got commited, it makes it alot easier than the things I was trying. So I might have a patch to get this rolling shortly.

shadowdknight’s picture

Waiting for good news!

Michael Zetterberg fd. Lopez’s picture

Assigned: Unassigned » Michael Zetterberg fd. Lopez
Status: Active » Needs review
Issue tags: +D7 port patch
StatusFileSize
new6.84 KB

Here is a first stab at this. A kind of 1:1 port actually, using the D7 Queues API and cron instead of job_queue.

I plan on fixing some additional things in the issue queue as well that will be build on top of this D7 port patch. But I'm trying to keep this patch clean from improvements. The patch is done from 6.x-1.x branch in git. Not sure if that is the appropriate way to handle a major version port, if not let me know :)

Oh, and remember you have to apply the committed patch in #800434: drupal_mail, allow hook_mail_alter implementation to cancel mail otherwise this will NOT work.

Michael Zetterberg fd. Lopez’s picture

StatusFileSize
new6.84 KB

For some strange reason I made the mail keys a white list rather than a black list. Here's the correct (black list) version.

Michael Zetterberg fd. Lopez’s picture

StatusFileSize
new6.84 KB

Fixed the new line bug with properly quoted \n.

shadowdknight’s picture

Thanks for porting this,
just to confirm, we need to apply this version of patch?
http://drupal.org/files/hook_mail_alter-cancel-800434-90.patch

Thanks!

Michael Zetterberg fd. Lopez’s picture

just to confirm, we need to apply this version of patch?
http://drupal.org/files/hook_mail_alter-cancel-800434-90.patch

Yes correct. But also note that it is committed to Core.

steven jones’s picture

Going to work on this port over in a sandbox: http://drupal.org/sandbox/darthsteven/1572824

steven jones’s picture

Assigned: steven jones » Unassigned

Right so my sandbox is now up for review, I've not changed all the much, but Queue Mail now just transparently inserts itself into the mail sending process, and allows you to use other mail sending modules, like mimemail to do the actual email sending.

greggles’s picture

Thanks for working on this. If any of you want to, I suggest asking to become a co-maintainer of the module for the 7.x branch. It would be great to see this committed and a release created.

steven jones’s picture

Status: Needs review » Fixed

I've pulled in the branches.

Status: Fixed » Closed (fixed)
Issue tags: -D7 port patch

Automatically closed -- issue fixed for 2 weeks with no activity.