Closed (fixed)
Project:
Queue Mail
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
5 Mar 2011 at 16:13 UTC
Updated:
3 Jan 2014 at 02:58 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
basicmagic.net commentedsubscribe
Comment #2
kehan commentedsubscribing too
Comment #3
jdleonardsubscribing
Comment #4
ktleow commentedComment Notify brings me here for scheduling emails.
Looking forward for D7 port.
Comment #5
BeaPower commentedsub
Comment #6
shadowdknight commentedany temporary solution until we wait for the port?
Comment #7
Michael Zetterberg fd. Lopez commented+1
Comment #8
Michael Zetterberg fd. Lopez commentedI've been giving a try at a patch for this issue. Good news is that #800434: drupal_mail, allow hook_mail_alter implementation to cancel mail got commited, it makes it alot easier than the things I was trying. So I might have a patch to get this rolling shortly.
Comment #9
shadowdknight commentedWaiting for good news!
Comment #10
Michael Zetterberg fd. Lopez commentedHere is a first stab at this. A kind of 1:1 port actually, using the D7 Queues API and cron instead of job_queue.
I plan on fixing some additional things in the issue queue as well that will be build on top of this D7 port patch. But I'm trying to keep this patch clean from improvements. The patch is done from 6.x-1.x branch in git. Not sure if that is the appropriate way to handle a major version port, if not let me know :)
Oh, and remember you have to apply the committed patch in #800434: drupal_mail, allow hook_mail_alter implementation to cancel mail otherwise this will NOT work.
Comment #11
Michael Zetterberg fd. Lopez commentedFor some strange reason I made the mail keys a white list rather than a black list. Here's the correct (black list) version.
Comment #12
Michael Zetterberg fd. Lopez commentedFixed the new line bug with properly quoted \n.
Comment #13
shadowdknight commentedThanks for porting this,
just to confirm, we need to apply this version of patch?
http://drupal.org/files/hook_mail_alter-cancel-800434-90.patch
Thanks!
Comment #14
Michael Zetterberg fd. Lopez commentedYes correct. But also note that it is committed to Core.
Comment #15
steven jones commentedGoing to work on this port over in a sandbox: http://drupal.org/sandbox/darthsteven/1572824
Comment #16
steven jones commentedRight so my sandbox is now up for review, I've not changed all the much, but Queue Mail now just transparently inserts itself into the mail sending process, and allows you to use other mail sending modules, like mimemail to do the actual email sending.
Comment #17
gregglesThanks for working on this. If any of you want to, I suggest asking to become a co-maintainer of the module for the 7.x branch. It would be great to see this committed and a release created.
Comment #18
steven jones commentedI've pulled in the branches.