Closed (fixed)
Project:
Drupal core
Version:
5.1
Component:
other
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
10 Jan 2007 at 14:35 UTC
Updated:
26 Jul 2007 at 08:15 UTC
Jump to comment: Most recent file
On the Drupal downloads page http://drupal.org/project/drupal there is "Read a complete log of changes" which in turn links to http://drupal.org/CHANGELOG.txt
This CHANGELOG.txt appears to be from the 5.x-dev development snapshot. It does not include the log of changes for version 4.7.x where x>0. This isn't great. There are a few things that could be done:
- Have a comprehensive CHANGELOG.txt which shows a collated change log across 5 RC1, 4.7.5 & 4.6.11
- Use the CHANGELOG.txt from the most recent production release (i.e. 4.7.5).
- Use the CHANGELOG.txt from the latest candidate release (i.e. v5 RC1), so long as it includes the 4.7.5 changes.
I prefer #1 and suggest that it should be comprehensive for the current production release(s). If you're playing with a dev or RC version then it's reasonable to assume you'll find the appropriate CHANGELOG.txt
In any case it should be made clear what changelog the link points to. If it stays at the 5-dev version (which I don't think is appropriate) there should also be an explanation how to get to the appropriate changelog for any given production release.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | CHANGELOG_51patch.txt | 627 bytes | vjordan |
| #9 | changelog_v5.patch_1 | 2.26 KB | dww |
| #8 | changelog_v475.patch_1 | 1.25 KB | dww |
| #7 | changelog_v5.patch | 2.19 KB | vjordan |
| #6 | changelog_v475.patch | 1.17 KB | vjordan |
Comments
Comment #1
webchickActually, it seems to me that this might be an issue w/ the CHANGELOG.txt in HEAD... shouldn't this include the 4.7.x changes, or no?
Comment #2
vjordan commentedContinuing to show an inappropriate CHANGELOG.txt on drupal.org
Maybe even more inappropriate since 5.0 is out.
Comment #3
sepeck commentedthe changelog link was to drupal.org installed versions changelog which is what it's been for years. Changed it to cvs current for v5
Comment #4
vjordan commented@sepeck:- not sure this really resolves the issue I posted originally. I logged this issue was when I was assessing whether to move from 4.7.4 to 4.7.5 to fix the security hole that had been identified. I wanted to see what else was included in the version change. The "complete log of changes" said nothing about what changed between 4.7.4 and 4.7.5. The changelog linked in now doesn't either (only 4.7.0 shown).
It would be good if there's a consolidated changelog that can be linked in the appropriate place. I'm guessing that doesn't exist because of the way the branching works so perhaps we can add a sentence to the last paragraph higher up this page:-
Information on version numbers and System Requirements can be found in the handbook. A full list of changes for each release is available in the file CHANGELOG.txt in each download.
Comment #5
dwwyes, this is a bug. i pointed it out (again) minutes before 5.0 was released, and was told "it's not critical, we'll fix it later". alas. someone just needs to generate a patch against the various branches that includes the missing CHANGELOG.txt entries from other versions. e.g.:
DRUPAL-4-7 needs all the 4.6.x changes
DRUPAL-5 needs all the 4.6.x and 4.7.x changes
HEAD needs all the 4.6.x and 4.7.x changes (it's already got the 5.0 entry, but it'll probably need a different patch to apply cleanly).
this is seriously "low-hanging fruit" patch material. ;) anyone care to do it? perhaps someone from the drupal-dojo could use it as their chance to get their first patch committed to core. ;)
cheers,
-derek
Comment #6
vjordan commentedpatches attached for v4.7.5 CHANGELOG.TXT
and for v5.0 CHANGELOG.TXT
I've checked these patches and they work cleanly for me. But I've a fairly poor development environment and these patches need to be looked over well. If they're looking reasonable I'll have a go at a patch for HEAD too.
Comment #7
vjordan commentedand as I said, for v5.0 CHANGELOG.TXT
Comment #8
dwwalmost, except that the patches had DOS line endings, and are against CHANGELOG.TXT, not CHANGELOG.txt.
i just re-rolled your patch to remove these problems, otherwise, it's identical. here's the 4.7 version.
Comment #9
dwwand here's the 5.x version. thanks for the patches!
-derek
Comment #10
dries commentedCommitted to all branched. Thanks a lot.
Comment #11
(not verified) commentedComment #12
vjordan commentedRelease 5.1 reintroduced a divergence in the changelog.txt content. There is an argument to let changelog diverge at branch points, I suppose. But I still reckon there's value having a consolidated changelog.txt
Here's a patch for changelog.txt for v5.1 which I think works. More importantly HEAD needs a similar patch to be applied covering v5.1 and v4.7.6 (which I can provide if it's appropriate). But is there some way to avoid having to do these retrospective patches? Can the build/release process include a step to consolidate CHANGELOG.txt details prior to release?
Comment #13
vjordan commentedComment #14
vjordan commentedComment #15
drummCommitted to 5.x.
Comment #16
(not verified) commented