The only way modules could change or get removed is during a migration or a clone. It cant happen during a verify process, as the platform has not been rebuild and stays the same. Therefore it is not needed to :
- clear the cache
- rebuild the nodeaccess table
- the menu tree
And all those others in clear_6.
Iam pretty sure people will argue here, as i see a lot of people hacking arround the "migrate" step, by modifiying the platform on the master, which already has been deployed ( e.g. by git pull or directly ), and using verify for resync with the remote. Why i understand the workflow, its still a hack. We should really stick to what we have in aegir:
1. if you want change a platform, create a new platform in aegir on base of this ( or use the make file )
2. migrate the old site to the new platform
This ensures that we know, that only migrate / clone can actually "change" number / site / version of modules, thus they need this kind of "clear". If someone "imports", it is expected to have the same codebase. If someone changes those version by any reason, we should add a simple task "rebuild caches" in the UI, so people can trigger this manually.
This "clear" is a completly overkill for larger installations and cannot just be done for the sake people hack aegir for development.
Nevertheless i created this patch to still support the old behavior by default, but adding the ability to set "rebuild_cash=false", so it get skipped. I leave the "discussion" what the default should be look like to the devs, i have simply added this to my .drush/drupalwiki.drush.inc (call it the way you like it) to disable those rebuild for me by default. ( this can be used for the UI also )
function drush_drupalwiki_pre_provision_verify() {
// never rebuild caches on verify of a site
if (d()->type === 'site') {
drush_set_option('rebuild_caches', FALSE);
}
}
Just for the "statistics" people:
- a site verify without cache rebuild takes 5 seconds
- a site verify with the current approach ( rebuild ) takes 2 min 25 sec
So its so its ~30 times faster.
| Comment | File | Size | Author |
|---|---|---|---|
| norebuild.patch | 555 bytes | eugenmayer |
Comments
Comment #1
eugenmayer commentedComment #2
anarcat commentedI have removed the node_access_rebuild() call from the cache clearing mechanism. I still think we should make verify flush the other caches.
Comment #3
eugenmayer commentedyou just destroyed the migration and clone process. Keep it going.
Dont expect me to open any issues or provide any patches anymore. You are really able to kill my motivation in every single way. I dont get any help when asking in, no help in the issues and no help in the support queues. And then those issues even are not investigated properly.
Iam really done with that, really.
Comment #4
anarcat commentedWe will keep going, no thanks to you.
I would be happy not having to deal with your abuse anymore. You are killing my motivation and making my regular flight into the issue queue just shitty.
We owe you nothing. We do not *have* to respond to your support requests. But we do anyways, in respect of the spirit of open source and to foster collaboration on this project.
We have responded every single issue you have opened. We have helped you to the best of our capacity. We have investigated every single you have opened, and if we couldn't fix it, we left the issue opened for later investigation, to make sure others could also peak into it. We have resolved hundreds of issues, more than 20 since you started participating in the issue queue.
We could also take our stuff and run in our corner when confronted with difficulties. We don't. We stick around for each other. We help each other. When things get tough, we talk and we resolve our issues. We don't run out and slam the door, like you have repeatedly done.
Now please decide out what you want to do: stay and contribute in a civil manner, or leave. I understand you have some issues with the way we handle issues here, if you do not like it, I suggest you start looking for somewhere else for your support needs.