Closed (fixed)
Project:
Provision
Version:
6.x-1.0-rc5
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
7 Mar 2011 at 09:45 UTC
Updated:
3 Jan 2014 at 02:58 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
thomas bosviel commentedI cleaned some stuff in hosting_dns module :
record_setmethod needs more checks on arguments ;Comment #2
thomas bosviel commentedAnother undefined index in dns.config.inc line 135
Comment #3
anarcat commentedOkay let's see here...
The second patch makes sense, and i am ready to merge it in, but the first one does much more than silence warnings.. I am especially worried about the removal of the $master argument to the create_zone(), as it is necessary for the slave to know which master to talk to... how are you handling that?
Now I understand that the create_zone() function is commented out in the slave right now, which i find puzzling, but maybe you can explain that to me. ;)
Seems like you're using the dns code a lot, are you interested in maintaining it?
Before this should be merged in, the functionality changes should be separated from the "php 5.3 warning fixes", if that's possible...
Thanks again...
Comment #4
thomas bosviel commentedI have separated "php 5.3 warning fixes" in a new patch (you need to remove old patches before applying this one).
About other fixes, each services (Dnsmasq, Bind and Bind slave) have a specific classe inherited from provisionService_dns because they need differents configuration files:
However, functions create_host, create_zone aren't overloaded to do exactly the right work. Each services use the same general function who deals with warnings to do the work. I think create_zone() function in provisionService_dns_bind_slave() class was originaly wrote to pass the master server IP to config class before generating the config file. Now, the master server IP is recovered from the context in the config class ... I have reused this code to solve this issue. I have created an other issue about that #1118286: [DNS] Each services need specific function to create config files.
Yes I'm interested to maintain the DNS module. What exactly is this work ?
Comment #5
thomas bosviel commentedThis patch solves all "php 5.3 warning" without changing the current design pattern.
Comment #6
anarcat commentedfix committed, thanks!
As for the DNS maintenance, it would mean you would go up from the bottom of that list to the top of that list:
http://community.aegirproject.org/node/553
ie. you would get commit access and would be able to commit your own patches. it would also mean you'd have to join in our weekly scrums...