Notice : Undefined index: host dans provisionService->config() (ligne 90 dans /var/aegir/.drush/provision/provision.service.inc).
Notice : Undefined index: dans provisionService->record_set() (ligne 138 dans /var/aegir/.drush/provision/provision.service.inc).
Notice : Undefined index: zone dans provisionService->config() (ligne 90 dans /var/aegir/.drush/provision/provision.service.inc).

Comments

thomas bosviel’s picture

Status: Active » Needs review
StatusFileSize
new5.04 KB

I cleaned some stuff in hosting_dns module :

  • Creating a zone configuration file is only required by the master ;
  • Creating a host configuration file is only required by the dnsmasq service ;
  • record_set method needs more checks on arguments ;
thomas bosviel’s picture

StatusFileSize
new6.07 KB

Another undefined index in dns.config.inc line 135

anarcat’s picture

Status: Needs review » Needs work

Okay let's see here...

The second patch makes sense, and i am ready to merge it in, but the first one does much more than silence warnings.. I am especially worried about the removal of the $master argument to the create_zone(), as it is necessary for the slave to know which master to talk to... how are you handling that?

Now I understand that the create_zone() function is commented out in the slave right now, which i find puzzling, but maybe you can explain that to me. ;)

Seems like you're using the dns code a lot, are you interested in maintaining it?

Before this should be merged in, the functionality changes should be separated from the "php 5.3 warning fixes", if that's possible...

Thanks again...

thomas bosviel’s picture

Title: "Undefined index" notices in hosting_dns module with PHP 5.3 » [DNS] PHP 5.3 warning fixes
Version: » 6.x-1.0-rc4
Status: Needs work » Needs review
StatusFileSize
new2.09 KB

I have separated "php 5.3 warning fixes" in a new patch (you need to remove old patches before applying this one).

About other fixes, each services (Dnsmasq, Bind and Bind slave) have a specific classe inherited from provisionService_dns because they need differents configuration files:

  • Dnsmasq needs to create server, zone and host configuration files
  • Bind needs to create server and zone config files
  • Bind slave needs to create server config files

However, functions create_host, create_zone aren't overloaded to do exactly the right work. Each services use the same general function who deals with warnings to do the work. I think create_zone() function in provisionService_dns_bind_slave() class was originaly wrote to pass the master server IP to config class before generating the config file. Now, the master server IP is recovered from the context in the config class ... I have reused this code to solve this issue. I have created an other issue about that #1118286: [DNS] Each services need specific function to create config files.

Yes I'm interested to maintain the DNS module. What exactly is this work ?

thomas bosviel’s picture

Version: 6.x-1.0-rc4 » 6.x-1.0-rc5
StatusFileSize
new2.64 KB

This patch solves all "php 5.3 warning" without changing the current design pattern.

anarcat’s picture

Status: Needs review » Fixed

fix committed, thanks!

As for the DNS maintenance, it would mean you would go up from the bottom of that list to the top of that list:

http://community.aegirproject.org/node/553

ie. you would get commit access and would be able to commit your own patches. it would also mean you'd have to join in our weekly scrums...

Status: Fixed » Closed (fixed)
Issue tags: -dns, -PHP 5.3 compatibility

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +dns, +