Closed (fixed)
Project:
Amazon Product Advertisement API
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
7 Mar 2011 at 14:44 UTC
Updated:
27 Feb 2018 at 16:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
panchoThis patch should cover the major part of the task.
Remaining issues:
- We need to ask the Drupal Association to create Amazon associate IDs for each locale besides amazon.com
- Javascript needed to make the Associate ID fieldgroup immediately reflect the chosen locale
Please test and review.
Comment #2
panchoComment #3
rfayThis looks OK to me, although I don't like the increased complexity. Probably necessary.
Note that Amazon Store will have to take advantage of this.
I'm going to put in "Needs work" because I know you're coming back to this for another round.
Comment #4
Anonymous (not verified) commentedSub; I would like to see this functionality.
Actually, I would like to have my sites take the user to the appropriate amazon.TLD depending on where the user is. I took a quick look at the patch and wasn't sure that is the supported behavior. If not, maybe it could be extended to do that (or maybe I should file a separate feature request issue!).
Comment #5
Anonymous (not verified) commentedAh, hmm, looks like that is #396554: Allow dynamic amazon locale choice. But it seems like that needs the functionality here!
Comment #6
Shadlington commentedHas this progressed at all over the past few months?
Comment #7
rfayShouldn't be too hard to get farther along with this. Your review will help. And if you want to ask the DA to get a couple of new associate ids....
Comment #8
willvincent commentedComment #9
willvincent commentedI've commit this.
Aside from storing multiple locale specific associate IDs, it doesn't really change much functionally just yet. However, it includes a list of product groups that are available for each locale, this will allow for configuring an instance of the asin field using autocomplete to limit results to a specific product group in a particular locale. Quite a bit more work to done on that front, but this portion fulfills the request this particular issue is about.
Comment #10
funature commentedAfter updating to the newest dev version which has this patch, I changed the field widget to "product name autocomplete", the widget works, but the field will not be displayed except using "ASIN as plain text" formatter.
Comment #11
willvincent commentedDid you run update.php?
Comment #12
funature commentedyes, i did. I will try to install it again, i hope it is not related to other module.
Comment #13
willvincent commentedwhat other module? Amazon Store? Latest dev of this has _not_ been tested with amazon store.
Comment #14
funature commentedi did a new install today, the formatter is working. I created an ASIN field and set the amazon locale to Germany, but the link is with the tag of US but not Germany. Anyone has the same problem?
Comment #15
willvincent commentedHmm there is probably more to look at for this
Comment #16
P.Smith commentedIt would be nice to take this a step further and allow the use of a geo plugin so that the Amazon ID relating to the visitor's country is selected (or the default one used). For now I'm looking at making a JavaScript solution to change US to the UK for my UK visitors (it's a site catering to both, albeit UK visitors make up the highest %).
Comment #18
marcelovaniLocale support works, but there is some work needed to fix the storage, see https://www.drupal.org/node/2920070
Comment #19
marcelovani