I've got a test site setup with the following...

Drupal 7
Views 7.x-3.x-dev
Shadowbox 7.x-3.0-beta3

I created an image content type with an image field. While viewing the image field shadowbox appears to be working correctly. I can click on the image in the node and the shadowbox pops up.

However, when creating a view that filters by image nodes, takes a taxonomy term as an argument, and displays the image field I'm unable to get shadowbox working. I simply see my images and they link directly to the full image. None of it is taking place with shadowbox.

What I'm trying to do is create a gallery of images based on taxonomy term. I'm not sure if I'm going about this the right way or not. I figured with views however I should still see shadowbox functionality.

CommentFileSizeAuthor
#18 shadowbox.module.zip4.71 KBmanfer
#12 shadowbox.module.zip4.8 KBmanfer

Comments

manfer’s picture

manfer commented

Have you tried generating the view and visiting the page that contains the view.

I have made I test and the problem seems to be it does not work in the preview that views generates. I can't figure out why. But after you efectively generate the view and visit it, the images shows as expected with shadowbox functionality.

I first thought about the shadowbox configuration parameter that allows only shadowbox in specific pages. By default it is excluding admin* paths. But, I have deleted admin* from the excluded paths and still not working on the view preview.

I have to try to figure it out a little more but there is the possibility to be a views issue (or views and shadowbox issue). The only difference I notice is that views is adding a class to the anchors in the preview:

<a class="views-ajax-processed-processed" title="" rel="shadowbox"....

and maybe that is preventing shadowbox to work on preview.

About if you are going on the right way. I think yes, you can do it that way. Please try to generate a view and visit that view instead of testing it in the preview and let me no if it works as expected.

caschbre’s picture

caschbre commented

Sorry for the confusion. I am looking / testing with the actual views page and not through the views preview.

One thing I noticed was that on the views page the only reference to shadowbox I find is on the link of the image.
rel="shadowbox[field_image]"
There is nothing else in the whole page that mentions shadowbox that I can find.

Now on the image node page I see reference to shadowbox all over the place with javascript, rel tags, etc.

I'm wondering if something is going on that is not loading the shadowbox functionality into my views page.

manfer’s picture

manfer commented

I understand that you first create an image content type to create image nodes. When you visit those nodes all works fine and images are displayed into shadowbox when you click the thumb. This content type besides can be categorized with some short of taxonomy.

Then you go and create a view for those node types, and you filter the nodes by taxonomy too. I really don't know if there is any view where you can provide just that. In the view I'm testing I have to configure the fields that are going to be shown too.

So one of the fields I have to configure is the image field itself. On that field I have to ensure I choose shadowbox as the formatter to display that field (otherwise the view will not use shadowbox).

Could be this what you are mixing? How do you configure the fields section of your view?

caschbre’s picture

caschbre commented

In the view I am displaying the Fields: Image and then selecting shadowbox as the formatter.

The view export is below if that helps. I'm sort of at a loss. 

$view = new view;
$view->name = 'gallery';
$view->description = 'Gallery';
$view->tag = 'gallery';
$view->base_table = 'node';
$view->human_name = 'gallery';
$view->core = 7;
$view->api_version = '3.0-alpha1';
$view->disabled = FALSE; /* Edit this to true to make a default view disabled initially */

/* Display: Defaults */
$handler = $view->new_display('default', 'Defaults', 'default');
$handler->display->display_options['access']['type'] = 'none';
$handler->display->display_options['cache']['type'] = 'none';
$handler->display->display_options['query']['type'] = 'views_query';
$handler->display->display_options['exposed_form']['type'] = 'basic';
$handler->display->display_options['pager']['type'] = 'full';
$handler->display->display_options['pager']['options']['items_per_page'] = '16';
$handler->display->display_options['pager']['options']['offset'] = '0';
$handler->display->display_options['pager']['options']['id'] = '0';
$handler->display->display_options['pager']['options']['expose']['items_per_page_options_all'] = 0;
$handler->display->display_options['style_plugin'] = 'grid';
$handler->display->display_options['style_options']['fill_single_line'] = 1;
$handler->display->display_options['row_plugin'] = 'fields';
/* Field: Fields: Image */
$handler->display->display_options['fields']['field_image']['id'] = 'field_image';
$handler->display->display_options['fields']['field_image']['table'] = 'field_data_field_image';
$handler->display->display_options['fields']['field_image']['field'] = 'field_image';
$handler->display->display_options['fields']['field_image']['label'] = '';
$handler->display->display_options['fields']['field_image']['alter']['alter_text'] = 0;
$handler->display->display_options['fields']['field_image']['alter']['make_link'] = 0;
$handler->display->display_options['fields']['field_image']['alter']['absolute'] = 0;
$handler->display->display_options['fields']['field_image']['alter']['external'] = 0;
$handler->display->display_options['fields']['field_image']['alter']['trim'] = 0;
$handler->display->display_options['fields']['field_image']['alter']['nl2br'] = 0;
$handler->display->display_options['fields']['field_image']['alter']['word_boundary'] = 1;
$handler->display->display_options['fields']['field_image']['alter']['ellipsis'] = 1;
$handler->display->display_options['fields']['field_image']['alter']['strip_tags'] = 0;
$handler->display->display_options['fields']['field_image']['alter']['html'] = 0;
$handler->display->display_options['fields']['field_image']['element_label_colon'] = 0;
$handler->display->display_options['fields']['field_image']['element_default_classes'] = 1;
$handler->display->display_options['fields']['field_image']['hide_empty'] = 0;
$handler->display->display_options['fields']['field_image']['empty_zero'] = 0;
$handler->display->display_options['fields']['field_image']['click_sort_column'] = 'fid';
$handler->display->display_options['fields']['field_image']['type'] = 'shadowbox';
$handler->display->display_options['fields']['field_image']['settings'] = array(
  'image_style' => 'medium',
  'image_link' => '',
  'gallery' => 'field',
  'title' => 'title',
);
$handler->display->display_options['fields']['field_image']['field_api_classes'] = 0;
/* Sort criterion: Node: Post date */
$handler->display->display_options['sorts']['created']['id'] = 'created';
$handler->display->display_options['sorts']['created']['table'] = 'node';
$handler->display->display_options['sorts']['created']['field'] = 'created';
$handler->display->display_options['sorts']['created']['order'] = 'DESC';
/* Argument: Taxonomy: Term */
$handler->display->display_options['arguments']['name']['id'] = 'name';
$handler->display->display_options['arguments']['name']['table'] = 'taxonomy_term_data';
$handler->display->display_options['arguments']['name']['field'] = 'name';
$handler->display->display_options['arguments']['name']['default_action'] = 'not found';
$handler->display->display_options['arguments']['name']['style_plugin'] = 'default_summary';
$handler->display->display_options['arguments']['name']['default_argument_type'] = 'fixed';
$handler->display->display_options['arguments']['name']['validate_type'] = 'taxonomy_term';
$handler->display->display_options['arguments']['name']['validate_options']['vocabularies'] = array(
  'gallery' => 'gallery',
);
$handler->display->display_options['arguments']['name']['validate_options']['type'] = 'name';
$handler->display->display_options['arguments']['name']['validate_options']['transform'] = 0;
$handler->display->display_options['arguments']['name']['glossary'] = 0;
$handler->display->display_options['arguments']['name']['limit'] = '0';
$handler->display->display_options['arguments']['name']['transform_dash'] = 1;
$handler->display->display_options['arguments']['name']['break_phrase'] = 0;
$handler->display->display_options['arguments']['name']['add_table'] = 0;
$handler->display->display_options['arguments']['name']['require_value'] = 0;
/* Filter: Node: Published */
$handler->display->display_options['filters']['status']['id'] = 'status';
$handler->display->display_options['filters']['status']['table'] = 'node';
$handler->display->display_options['filters']['status']['field'] = 'status';
$handler->display->display_options['filters']['status']['value'] = '1';
/* Filter: Node: Type */
$handler->display->display_options['filters']['type']['id'] = 'type';
$handler->display->display_options['filters']['type']['table'] = 'node';
$handler->display->display_options['filters']['type']['field'] = 'type';
$handler->display->display_options['filters']['type']['value'] = array(
  'image' => 'image',
);

/* Display: Gallery Page */
$handler = $view->new_display('page', 'Gallery Page', 'gallery_page');
$handler->display->display_options['path'] = 'galleries/%';
$translatables['gallery'] = array(
  t('Defaults'),
  t('more'),
  t('Apply'),
  t('Reset'),
  t('Sort By'),
  t('Asc'),
  t('Desc'),
  t('Items per page'),
  t('- All -'),
  t('Offset'),
  t('All'),
  t('Gallery Page'),
);
manfer’s picture

manfer commented

I can't see anything wrong in that configuration. About the field configuration I only can't find any place to configure the following one. I really don't know which is this setting.

$handler->display->display_options['fields']['field_image']['field_api_classes'] = 0;

In my test the only different is that I have no filter criteria other that node type image. But all those filters, including the parametrized taxonomy looks fine and they are only going to reduce the number of nodes on the view, should not have any to do with the display formatter shadowbox.

Besides if I understood correctly your view shows images but the problem is that shows only the thumbnail (medium size is what you have configured) and when you click instead of the shadowbox it appears in the window.

Maybe the problem is that the library is not being included in your page for some reason and having nothing to do with the view. It would be helpful to see a testing site online to inspect the code. Otherwise I only can tell you how to test if shadowbox library is on those pages. If you know how to use the console on developers tools of your browser (firebug in firefox, the integrated tools in chrome and I think IE7 and above -or at least IE8- has tools too), go to that console and write Shadowbox and hit run, if the response shows an object:

Object { version="3.0.3", isMac=true, more...}

then shadowbox library is working on the page.

On an online test site I can do those kind of checks.

manfer’s picture

manfer commented

I have just done a test with taxonomies as arguments and works fine too for me. So if the view displays the images correctly, the ones corresponding to the term you are visiting, but they are not being displayed in shadowbox when you click on them, it is better to first check if shadowbox library is being loaded.

caschbre’s picture

caschbre commented

When I run Shadowbox on the image node I get the object you mention. When I try that on the views page it cannot find the reference.

I also shot you a URL via the contact form of a site to look at.

manfer’s picture

manfer commented

Nothing more I can imply from the testing site.

As you already checked Shadowbox object is not present in the view page. This indicates that shadowbox library is not being loading. Checking it I see it is not loaded indeed.

Now why is this happening is what needs to be understood:

- The error console does not report any error. The problem is not any javascript error then.
- So all must come from PHP. The server is not sending shadowbox library as part of that page.
- In shadowbox configuration /admin/config/media/shadowbox you have settings to include/exclude paths where you don't want shadowbox to be used, "page specific activation settings". By default it excludes admin*, img_assist*, node/add/* and node/*/edit. You should check if you changed something there that could be excluding your view path.
- Check too that the "Enable Shadowbox" checkbox in that same configuration page is checked.
- Being there just check too that clicking "check Shadowbox with the current settings" opens shadowbox.

If nothing of that works then I can't figure out yet why shadowbox is not being loaded.

caschbre’s picture

caschbre commented

Enable shadowbox is checked.
The include/exclude path settings are the defaults as you have listed.
Check shadowbox with current settings does indeed work.

Any other suggestions on how I could debug this?

manfer’s picture

manfer commented

You confirm the path settings are correct in the text area but above that you have 3 radio buttons: "Enable on every page except the listed pages.", "Enable on only the listed pages.", "Enable if the following PHP code returns TRUE (PHP-mode, experts only).". (this last one only appear if you have enough permissions).

The correct one that must be checked is "Enable on every page except the listed pages."

If you confirm you have that correctly configured then I would need to attach here a version with debug code to try to figure out why the shadowbox library is not being loaded.

caschbre’s picture

caschbre commented

Here are the settings.

Enable on every page except the listed pages.
admin*
img_assist*
node/add/*
node/*/edit

Interestingly enough, I don't see the "Enable if the following PHP code returns TRUE" option. I'm guessing only user #1 can see that option? I currently have every permission checked for my role on the user permissions page. But I'm guessing that alone isn't the issue.

manfer’s picture

manfer commented
StatusFileSize
new shadowbox.module.zip4.8 KB

The PHP option is only available for users with "Use PHP for settings" permission and that permission is only available if PHP filter core module is enable but has nothing to do with the issue.

The configuration is correct.

I attach a zip with shadowbox.module file that includes some debug code. Please install it over your actual shadowbox.module file and let me now the output when you visit one of your working image nodes and when you visit the view page.

caschbre’s picture

caschbre commented

Working image node page.

Shadowbox Enabled: 1
Shadowbox Auto: 0
Shadowbox Globally: 0
Testing if shadowbox should be exluded in this path. Shadowbox excluded: FALSE
Adding shadowbox library from field.

Views page

Shadowbox Enabled: 1
Shadowbox Auto: 0
Shadowbox Globally: 0
Testing if shadowbox should be exluded in this path. Shadowbox excluded: FALSE
Adding shadowbox library from field.
Testing if shadowbox should be exluded in this path. Shadowbox excluded: FALSE
Adding shadowbox library from field.

manfer’s picture

manfer commented

All looks correct. There must be a conflicting module creating this issue.

By now, you can revert the shadowbox.module file to the one included in the shadowbox module and use the auto handling feature "Enable shadowbox globally". You can find it under /admin/config/media/shadowbox/automatic. With that setting your views pages will work with shadowbox while the conflicting module is being tracked.

manfer’s picture

manfer commented

I have released a beta4 with a minor change. I'm not sure if this could be affecting in your case. It would be helpful if you could try this beta4 with the auto handling feature "Enable shadowbox globally" disabled.

I'm unable to reproduce the issue so I can't test if the change made in beta4 solves it.

caschbre’s picture

caschbre commented

I'll try to give this a shot tonight or over the weekend and report back what I find.

caschbre’s picture

caschbre commented

Unfortunately the upgrade didn't solve the issue. :(

manfer’s picture

manfer commented
StatusFileSize
new shadowbox.module.zip4.71 KB

Is the test site still online to do other test? To know if this has something to do with a hacked theme it would be nice to test if changing the theme to other core theme and configuring shadowbox without "Enable shadowbox globally" checked, the issue remains present or not.

If still present I append another shadowbox.module with minor changes. In that new file I'm attaching shadowbox library a level deeper. Let's try if this works. I wonder if any module is just overwriting the '#attached' attribute instead of appending to it which is what should be done I think. With this change maybe shadowbox '#attached' attribute is not overwriten. This will give me the answer though I don't know if I'm going to be able to track which module. To do this test you would have to change your shadowbox.module with this version and besides, as on the rest of test, disable the checkbox "Enable shadowbox globally" in shadowbox auto handle configuration.

manfer’s picture

manfer commented
Version: 7.x-3.0-beta3 » 7.x-3.0-beta4
caschbre’s picture

caschbre commented

I checked the theme out and there are no modifications to it. I also tried another core theme and still had the same issue with shadowbox.

I'll install the new copy you attached and give that a run.

caschbre’s picture

caschbre commented

The module attached in #18 did the trick.

manfer’s picture

manfer commented

Thanks a lot.

What I can imply of your tests, is that the theme was not the problem so it has to be a module.

A module must be overwriting my attached attribute that adds the shadowbox library to the page. That module must be doing something like.

['#attached']['library'] = array xxxxxxx (overwriting)

instead of:

['#attached']['library'][] = xxxx (appending)

But I have no clue which module. I have tested the list you let me gather from your site but with default values the problem is not appearing for me. So I can't know which one is the cause. The only way to find out which one is the problematic module would be to revert shadowbox to beta4 version and disable all modules instead of core ones and shadowbox itself and then enabling the other modules until the problem appears.

Anyway I'm going to try to ask in field API forum to confirm I'm attaching the library correctly or if it is better to turn to the code in this last version than you confirmed is working. Maybe I doing it wrong and is better this last code.

Thanks.

process91’s picture

process91 commented

This same thing happened with my site. The attached file from #18 also fixed it on my site. I'd be happy to provide debug information for you to cross-reference.

manfer’s picture

manfer commented

I have send a question to field core system to try to determine if actual code is wrong and would be better to change it to the one in #18 or to something totally different but still not answer.

If actual code is correct then there is another module with a bug that affects shadowbox. Really I don't know how to debug so deeper to find who is that module overwriting shadowbox code, if any. I could think of views itself but in my test site with shadowbox and views, works fine without any modification on shadowbox.

I will continue investigating this.

Thanks.

manfer’s picture

manfer commented

Maybe someone with good knowledge of field core system in drupal 7 comes to this issue and is able to answer the question I made in drupal core. Here is the issue:
http://drupal.org/node/1091076

If someone is able or knows anyone able to answer that question, it would be really helpful.

Thanks.

manfer’s picture

manfer commented
Status: Active » Fixed

I had no luck with my question about this issue but as this other way to add the library looks fine for me too and corrects this issue with views, I decided to include this change in the new version 7.x-3.0-beta5.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit e9a6b11 on 7.x-3.x, 8.x-1.x by manfer: 
    by manfer: Added disable warning in settings page. Issue #1107162 by...