I didn't know where else to put this, so I've created an issue for it and attached the solution.
The patch also includes bug fixes in regards to opensearch_bindings in other modules (the module broke when none existed) and some performance improvements on the search and replace algorithm for the template URL.

I really like this module... so well done and thanks for making life easier for those of us who enjoy standards.

Are you working with the OpenSearch Aggregator group? Why is another project being created for this? etc etc.

CommentFileSizeAuthor
#5 opensearchclient4.patch5.62 KBnterbogt
opensearchclient.patch7.27 KBnterbogt

Comments

robertdouglass’s picture

robertdouglass commented

This looks very good. One question about the location of this call:

       // Get information on other modules that are interested in the RSS results (like Nutch) by calling the 'opensearchclient_bindings' hook
       $opensearchclient_bindings = opensearchclient_get_module_bindings();

Any reason why you moved it to within the ensuing foreach loop? I don't think that calling it each time should make a difference (in fact would be wasteful). I'll wait for your comment before I commit. Nice work.

nterbogt’s picture

nterbogt commented

Sorry, an oversight on my part. Happy to move it back up the function in order to speed things up a little :)

robertdouglass’s picture

robertdouglass commented
Status: Active » Fixed

Committed. Thanks!

robertdouglass’s picture

robertdouglass commented

Could you backport your improvements to 4-7?

nterbogt’s picture

nterbogt commented
StatusFileSize
new opensearchclient4.patch5.62 KB

Here's the patch for the 4.7 branch.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)
nterbogt’s picture

nterbogt commented

Hi Robert,
Any comments on the patch for 4.7? I've found another issue with opensearchclient, and I'm working on providing a patch for that now.
Thanks.