Simple and great! Congratulations for your work!
I found one tiny bug, which resulted in several days of troubleshooting. Please correct this, to avoid another similar situation: the "container" as used in CSS class conflict with the "Forum", and the "Advanced Forum" modules row css class. This defect of the Opera and Firefox sensitive. I get up rename it to something else, such as "conlayer"

Bye,
DTB

Comments

andregriffin’s picture

andregriffin commented

I'm not seeing this problem with the built-in Forum module. Can you confirm that there is a problem when only using the built-in Forum module?

It's a shame that a module like Advanced Forum would claim such a broad class name, rather than "forum-container". Really, the change should be in the Advanced Forum module. If they refuse, it should be done by the user, or I'll change it to "page-container" or something.

DTB’s picture

DTB commented

Hi Andre,
Used modules:
author_pane-6.x-1.1 and
advanced_forum-6.x-1.1
View the source code (advanced_forum.module, line 708)

if ($ forum-> is_container) {
       $ row_classes .= 'container';
     }

... and look at the CSS:
# forum td.container {...}
These references can be found in several places.
I'm sorry, I can not test, because I change the "framework" conflicting parts. (it seemed easier)
I have no problem, since it has been corrected, I just pointed out, because the error caused by conflicting names is very difficult to find it (half day), and the other does not become so.
After all, this is not a bug, a fault, just unfortunate coincidence :-)

andregriffin’s picture

andregriffin commented
Status: Active » Closed (won't fix)

I just realized I no longer use this class name in the 3.x version, and I don't plan on updating the 2.x version. Since Framework users should not have any need to "Update" their themes (see #1074800: Improve usability for unexperienced users), users should simply choose the 3.x version for future projects. Thanks for letting me know of the problem anyway!