upgrade to 5.0

This seems to work without any change to the main functions. Attached is a patch that removes the help function. You will also need to create the .info file as follows:

; $Id $
name  = Sympal book menu
description = Displays book navigation in the main menu.
version = "$Name: DRUPAL-5 $"

Did it work on 5.0, after the patch?

OK, it works fine.

I hope to make some changes, though.

1. Add the book's weight to the menu.

2. Add a settings page with an option to select the parent menu item.

Also, the module creates duplicate content since all menu URLs start with book_menu.

Here is my working 5.x version.

I've integrated the code above, with the following additions:

1. Book items weight is now transferred to the menu, so that menu items are sorted by book weight.
2. Menu is rebuilt automatically when new book pages are added.
3. Better SEO compatibility: Avoiding duplicate content by using standard URLs ('node/...') instead of the previous URLs (book_menu/....). This works great with the nice_menus module, if you enable a nice_menus block.
4. Functions renamed to start with the module name and adhere to the standard drupal naming conventions

Known issues

The standard SEO URLs work great with nice_menus, but compatibility with the standard drupal 5 "Navigation" block remains an issue, since the book menu items can't not expanded.

What's next

• I would be glad if someone commits this new version into the code repository and maintains the module further
• Create a module's settings page and make SEO-friendly URLs an option or solve the navigation bug

Wow, I had already updated the module to work with D5 for a site of mine, and was just looking at the code wondering how to sort out the problem of the Node local tasks not showing up, when I found your revised module. It works great - so many thanks to levavie for contributing it!

As you say, it would be great if somebody could commit the new version to CVS. This is a very handy little module.

Could it be ported to 6.2 ?

please provide proper patches and keep to the issue.

Adding new features to a module in a thread called "upgrade to X" will only slow down that upgrade.

Let us
a) focus on the upgrade
b) use the proper patching and diffing: http://drupal.org/patch/create

Ber,

I think part of the problem is that there is currently only a 4.x release, so everybody (including me) is rolling their own 5.x version and adding their own bells and whistles to it. Since the maintainer doesn't seem to be active, there doesn't seem to be a way to get a base 5.x release committed. As I said in a comment above, it would be great if levavie's version above could be committed as a 5.x release, and then we could submit patches against that. I might be wrong, but I assume that one can't submit patches against the 4.x version for the 5.x version?

yes I know: but reviewing and testing a tarball is much harder then a patch.

Ber,

Fair enough. The main reason I haven't made any patches up to now is my lack of experience with CVS (I use Subversion) but I've now installed it (following the instructions in this Lullabot video - http://www.lullabot.com/videocast/install_cvs_mac_osx - if anybody else is interested) and will try my hand at patching when I get a moment.

Great work, guys!
It's unique module, that must «to advance the frontier of drupal science» =)

good use with d5.10, but the active trail «non est» =(