When I edit a node and attempt to attach an image file, the ImagePicker edit screen is completely unreadable due to a dark blue background. See attached screen shot. This only seems to happen when using the Marinelli theme (I have 7.x-3.0-beta9 installed). When I switch to Garland, it's fine (the edit box background comes out a perfectly readable light blue).

CommentFileSizeAuthor
image-picker.png59.62 KBroy smith

Comments

hutch’s picture

hutch commented
Category: bug » support
Priority: Major » Normal

This is not a bug, this is a theming issue. Copy imagepicker.tpl.php to your theme and edit it to suit your needs. Remember to flush the cache so that Drupal picks up the new template. If you add an HTML comment to it and look at the source of the iframe you can check that it has picked up the right template.

roy smith’s picture

roy smith commented

If I understand you correctly, you're saying this is a bug in the Marinelli theme?

hutch’s picture

hutch commented

Not so much a bug as a different way of doing things, if you look at page.tpl.php you might be able to adapt imagepicker.tpl.php to work with marinelli.

roy smith’s picture

roy smith commented

Well, I don't know too much about drupal internals or theming, but if module X doesn't work with theme Y, then it's either a bug in X or a bug in Y. Should I open a bug against Marinelli?

hutch’s picture

hutch commented

Different themes use different ccs ids to wrap things in, you need to find out which one is making the background dark and override it in imagepicker. There is no common standard for css wrappers.

roy smith’s picture

roy smith commented

Opened a bug against Marinelli for this (http://drupal.org/node/1085450)

roy smith’s picture

roy smith commented

Hmmm, I see my last comment and the previous one sort of crossed in the mail. I'm not trying to be a pain about this, but this is a problem which needs to get addressed.

It sounds like the real problem is that themes and modules both play in the same CSS id namespace, and there's no mechanism or process to prevent id collisions. If so, then this kind of problem will happen again and again as people mix and match modules and themes (which is, after all, the whole idea). Kicking the issue back to the end user to hand-edit CSS isn't a solution that scales.

hutch’s picture

hutch commented

If you know of a way to get imagepicker.tpl.php to work in all themes including Marinelli out of the box then let me know, all I know is that it works in most themes and in zen in particular which is what I use for my sites.

roy smith’s picture

roy smith commented

A solution was suggested in #1085450: Marinelli does not work with Image Picker module, which seems to work.

hutch’s picture

hutch commented

#1085450: Marinelli does not work with Image Picker module
I haven't tested this but it looks like the right way to do things.

Aejjk’s picture

Aejjk commented

You could put this in your CSSfile

#imagepicker {background: #FFF;}

this solution worked for me.