Height override

unleached - January 11, 2007 - 14:11
Project:Greybox
Version:5.x-1.1
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:by design
Description

With drupal 5rc2 i had to remove

width: 400px;
height: 400px;

from #GB_window in order to use the settings provided in the admin/settings page.
Without it the height of the greybox window would shrink from its customized size to 400 px.
I'm not a developer, but I hope my findings might be of interest anyway. I've not tried to replicate the problem in other installations.

Anyways thanks for a great module! =)

#1

LoRaK - January 12, 2007 - 13:34

if height is disabled from #GB_window in greybox.css, the DOM inspector (Firefox) shows the height property in the style_"" rule of the #GB_window div element

if it is not disabled, the above mentioned property disappears, all others remaining (width, left, display)

#2

Grinin - January 17, 2007 - 07:49

I've got some strange problems with the popup window.

In firefox it doesn't look too bad but I have a vertical scroll bar for no reason.

In internet explorer it loads a horizontal and vertical scroll bar, but I can't figure out why.

If someone could please help me figure this out I would greatly appreciate it.

This first screenshot is the issue in Firefox.

AttachmentSize
greyboxFF.jpg 49.87 KB

#3

Grinin - January 17, 2007 - 07:50

Here is the same issue, different effect in Internet Explorer 7

Any help would be appreciated.

You can reach me via the contact form on Drupal.org

Thanks!

AttachmentSize
greyboxIE.jpg 56.2 KB

#4

Gurpartap Singh - January 19, 2007 - 21:10
Status:active» by design

The code is actually:

function GB_show(caption, url, height, width) {
  GB_HEIGHT = height || 400;
  GB_WIDTH = width || 400;

  .....

}

Here, height || 400 means get the height variable's value, and if it's not available, set it to 400.

Hope you have the right copy of greybox's js.

 
 

Drupal is a registered trademark of Dries Buytaert.