user search form does not work

I found that the only thing that didn't work right for me was when I was on the user search page (http://drupal.org/search/user), I entered a user, and clicked "Search". When I did that I was taken to the node search results instead of the user search results.

The action in the user search form is set to "/search/node".

My guess is that this is in the search module. I can't reproduce the problem in RC1. Since RC1 there has only been one patch applied to the search module and it dealt with "Clean up search menu items, fixing .../search/user under certain permissions."

The diff is at http://cvs.drupal.org/viewcvs/drupal/drupal/modules/search/search.module...

search_menu() defines the callback argument 'node' to the 'search' path.

Submit a search for user 'joe'. The callback /search/user/joe is all set up with the callback argument 'user'. Great.

But this is never called because menu.inc looks at the path ('search/user') and never calls the callback at 'search/user/joe'. So it calls the callback for 'search' instead. But search_menu() defines the callback argument 'node' to the 'search' path.

There's the problem. One solution is to redirect to /search/user/joe which works fine.

I will roll back http://drupal.org/node/102040 and re-fix that one.