Closed (fixed)
Project:
Voting API
Version:
master
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
11 Jan 2007 at 16:54 UTC
Updated:
7 Apr 2007 at 01:16 UTC
Jump to comment: Most recent
VotingAPI's current method of handling the user's hostname in votingapi_add_vote() uses HTTP_X_FORWARDED_FOR is if exists, otherwise it defaults to REMOTE_ADDR. The problem with this method is that HTTP_X_FORWARDED_FOR could be the same for many different computers on different networks. It should only be used in relation to REMOTE_ADDR.
So, this patch appends HTTP_X_FORWARDED_FOR to REMOTE_ADDR if it exists, rather than replacing it entirely. This also makes it easier to detect voting fraud, as HTTP_X_FORWARDED_FOR can be manipulated by the user and isn't entirely trustworthy.
| Comment | File | Size | Author |
|---|---|---|---|
| votingapi_hostname.patch | 980 bytes | ChrisKennedy |
Comments
Comment #1
eaton commentedCommitted. Thanks!
Comment #2
Anonymous (not verified) commentedWhat do I need to do to get this installed?
Comment #3
(not verified) commented