I dunno what this wants to be or why it's not git diff or git describe or whatnot but once thing for sure: this command doesn't work. Here http://drupal.org/node/1059322
I dunno what this wants to be or why it's not git diff or git describe or whatnot but once thing for sure: this command doesn't work. Here http://drupal.org/node/1059322
Comments
Comment #1
logickal commentedTalking with chx in IRC I think that one little bit of confusion in this documentation block is that it isn't necessarily clear that you have to have committed your changes to use format-patch to generate the output. Personally, I'm a commit-early, commit-often kind of person, but for those people who just clone a module's code, fix a line and expect to be able to put a patch up, this is going to cause them great confusion.
Any thoughts?
Comment #2
chx commentedA solution would be to link to the patch page explain there the available commands and leave this section out. If you are maintaining a project you won't be patchin' anyways.
Comment #3
chx commentedComment #4
pwolanin commentedThe instructions at #1054616 were causing a variety of confusion and aggravation. For example, I got in one project queue format-patch file with 3 commits to change one line of code. Encouraging the use of mutiple commits and git format-patch as that doc did makes it very hard or impossible to review patches in the browser or with dreaditor as many active d.o users are accustomed to doing.
I rewrote http://drupal.org/node/1054616 to encourage use of git diff instead, and only using format-patch for a single commit so it's possible to do in-browser review. I also moved to that section and edited/updated scor's doc http://drupal.org/node/707484 which has a simple no-branch/no-commit workflow that many people new to git find easier to understand.
Note: I discussed a lot my motivations for the change in IRC with rfay, sdboyer, chx and others
The basic changes are already there. Might need a follow-up issue to refine the instructions on the git tab so suggest using git diff by default. Also, apparently there are some issues with the testbot not understanding all core versions in a -Dx suffix, e.g. -D7 or -D8
Comment #5
pwolanin commentedfollow-up issues:
#1092226: Fix git tab instructions to suggest using "git diff" instead of "git format-patch"
#1092232: Bot needs to handle patches named for all core versions -D[678]
Comment #6
joachim commented> If you are maintaining a project you won't be patchin' anyways.
You will if you co-maintain -- guidelines say to upload a patch to an issue :)
Comment #7
pwolanin commentedIndeed - I try to upload the patch I commit to give insight to my co-maintainers, and since often we share the workload in terms of backports, etc.