Error accepting when there are multiple requests

I can confirm this...

The error in the buddylist.module code is at these functions....

• buddylist_pending_requester_list(&$account)
• buddylist_pending_requested_list(&$account)
• buddylist_pending_requester_list(&$account)
• buddylist_pending_requested_list(&$account)

It seems to be around this repeated snippet of code...

    while ($row = db_fetch_object($result)) {
      $html_row = array();
      $html_row[] = theme('username', $row);
      $html_row[] = drupal_get_form('buddylist_request_cancel_', buddylist_request_cancel_form($row->uid, $account->uid));
      $html_rows[] = $html_row;
      $rownum++;
    }

Looking at the above, the drupal_get_form() is called to create a form for each user in the list, but passes EXACTLY the same $form_id for each iteration.

Form.inc expects unique $form_ids per page.

When form.inc handles the submit, as all of the forms are the same name, we always get back the first form, or in other words user on the list.

Therefore, this section of the code is probably invalid and requires rework to stop this 'feature' happening for all the above functions !!!

Can anyone else help further this on?

i have been using buddylist.module,v 1.48.2.40 2007/01/05 18:49:23 fago Exp $

thanks but your version throws a wobbly under 4.7.5, i can see it is for dru 5.0 only (e.g. drupal_mail calls)

unfortunately, there are too many changes for me to decypher what is what, maybe someone can backport?

anymore for anymore ?

this solution is near to dldege´s but the rest of the module is untouched...

thanks for your work.

But could you clean it up a bit more, before it goes in please:

• I wasn't able to apply your patch. If you use eclipse for generating patches please select the project as patch root
• remove unwanted changes from the patch, like new lines (@@ -453,6 +473,7 @@) and commented out code
• there are some tabs in the code, e.g. before $items[]
• also each array key should have its own line -> callback arguments
• there is also no weight needed for callbacks, as they aren't visible
• buddylist_approval_form()'s name is a bit misleading now, isn't it more a part of the confirm_form now?
• also the $requestee_uid is duplicated in its signature, as the uid is in the account object too
• there shouldn't be a drupal_goto() in a form api submit function, use its return value. furthermore I think the best default return value would be the buddylist of the user
• if you load the requester_account only on submit, you could load it only if the mail has to be sent too
• you forgot to use t() inside the l() functions
• language! please stay with the official buddylist language, there is no invitation and network but a request and a buddylist ;)

Furthermore I wondered if this issue applies to the cancel buttons to?

here with the favoured changes, also including the cancel buttons ;)

thanks, this will fix a lot of bugs. however there are still some invite-phrases in there - buddylist does requests, but no invites.

yep, I agree, however this is another issue. Feel free to open one.. I'd be happy about a patch.

one more, with - i hope so - correct phrases

damn, now it doesn't apply any more!
could you please reroll it against the latest code?
(there was a commit recently: http://drupal.org/cvs?commit=60462)

now it should work ;)

thanks!!
Committed to 5.x and HEAD.

Has this been backported to 4.7?

no, feel free to provide a patch..

Personally I'm concentrating on 5.x now, as I'd prefer one stable branch to two buggy branches.. However, of course any backports of fixes are welcome!