drush test-run ignores port in --uri argument [#1087002]

If you are attempting to run test cases against a server where the port is not 80, drupalGet / drupalPost will fail. For example:

$ drush test-run --uri=http://localhost:8888/drupal7/ EnableDisableTestCase --methods=testEnableDisable

I took a look at #580530: Command to run simpletests and there doesn't seem to be anything specifically related to the URI in the commit, so I wonder if this is a deeper problem with the --uri option.

Comment	File	Size	Author
#5	108002_5_respect_uri_port.patch	2.6 KB	deviantintegral
#3	108002_3_respect_uri_port.patch	1 KB	deviantintegral
#2	1087002_2_respect_uri_port.patch	695 bytes	deviantintegral

Comments

Comment #1

greg.1.anderson commented 9 March 2011 at 21:06

Here's the relevant code in environment.inc:

    $drupal_base_url = parse_url($drush_uri);
    // If there's no url scheme set, add http:// and re-parse the url
    // so the host and path values are set accurately.
    if (!array_key_exists('scheme', $drupal_base_url)) {
      $drush_uri = 'http://' . $drush_uri;
      $drupal_base_url = parse_url($drush_uri);
    }
    // Fill in defaults.
    $drupal_base_url += array(
      'path' => NULL,
      'host' => NULL,
    );
    $_SERVER['HTTP_HOST'] = $drupal_base_url['host'];
    if (array_key_exists('path', $drupal_base_url)) {
      $_SERVER['PHP_SELF'] = $drupal_base_url['path'] . '/index.php';
    }
    else {
      $_SERVER['PHP_SELF'] = '/index.php';
    }

As you can see, the port component from parse_url is not considered. It should be fairly easy to put it in; patches welcome.