I would be worth putting a warning in the Readme that extracting the excanvas_r3.zip does not create the excanvas_r3 directory. You must create the directory manually and extract the zip from within it, or the files will all extract into the other_libs directory.

CommentFileSizeAuthor
#4 beautytips-1087028-excanvas_r3_zip_extract_location.patch1.14 KBxurizaemon

Comments

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
Status: Active » Needs work

I think this is dependent on your extraction environment.

I had this issue when extracting excanvas_r3 on linux using unzip, but people on OSX or Windows will probably get the folder created automatically.

DrewMathers’s picture

DrewMathers commented

While it is true that Windows will default to creating a subdirectory based on the zip file name, the typical practise with most libraries and all Drupal projects is to create the zip from the parent directory, so the subdirectory will be created during extraction.

jason.fisher’s picture

jason.fisher commented

On Ubuntu, it did not create the subdirectory and made a mess of other_libs.

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
Status: Needs work » Needs review
StatusFileSize
new beautytips-1087028-excanvas_r3_zip_extract_location.patch1.14 KB

ok, here's a patch then

pifagor’s picture

pifagor commented
Issue summary: View changes
Status: Needs review » Closed (outdated)