Home » Download » Drupal project » Drupal » Issues

Code style clean-up: contact.module

add1sun - January 12, 2007 - 00:41
Project:Drupal
Version:5.x-dev
Component:contact.module
Category:bug report
Priority:minor
Assigned:neclimdul
Status:closed
Description

Here are some coding standards errors caught by Coder module

AttachmentSize
contact-cleanup.patch1.08 KB
» Login or register to post comments

#1

add1sun - January 12, 2007 - 14:11

Corrected patch.

AttachmentSize
contact-cleanup_0.patch1.37 KB
Login or register to post comments

#2

drumm - July 15, 2007 - 23:51
Status:patch (code needs review)» patch (code needs work)

I think the parentheses around those return values are not helping anything; they should be removed.

Login or register to post comments

#3

neclimdul - August 16, 2008 - 04:27
Assigned to:Anonymous» neclimdul
Status:patch (code needs work)» patch (code needs review)

Yuck! Luckily fixed in 6 and beyond but we can fix this still...

AttachmentSize
108717.patch1.37 KB
Login or register to post comments

#4

drumm - September 15, 2008 - 06:19
Status:patch (code needs review)» fixed

Committed to 5.x.

Login or register to post comments

#5

Anonymous (not verified) - September 29, 2008 - 06:21
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

Login or register to post comments
 
 

Drupal is a registered trademark of Dries Buytaert.