In http://drupal.org/node/808518, Mimemail module is preparing an API change. Now mimemail() returns a boolean but after this API change will return an array with the whole message. The actual boolean will be included in return array as key "result".

Fro, PHPDoc:

* @return
*   An array containing the MIME encoded message, including headers and body.

Webform must adapt to the new Mimemail API.

CommentFileSizeAuthor
#3 webform_1087598_02.patch754 bytessgabe
#1 webform-1087598.patch975 bytesclaudiu.cristea

Comments

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Active » Needs review
StatusFileSize
new webform-1087598.patch975 bytes

Here's a patch to be applied after http://drupal.org/node/808518 commit.

quicksketch’s picture

quicksketch
he/him
commented

Thanks, though could we make an backwards compatible change? It's a serious pain trying to get modules to work together when we have a mid-cycle API change like this. Perhaps a condition like this would work for both versions of MIME Mail?

if ((is_array($message) && $message['result']) || (!is_array($message) && $message)) {
sgabe’s picture

sgabe commented
StatusFileSize
new webform_1087598_02.patch754 bytes

Good point, Nathan. See the attached patch.

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs review » Fixed

Thanks sgabe, committed. We should have a new Webform release by mid-next week. I really appreciate the heads up.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.