I have developed a new module for a client project to assist with the translation of the web site which connects using HTTP API calls to an external translation server at Sprawk.com. I want to submit this module so that other Drupal sites can choose to use this alternative to Google translate. The Sprawk translation service requires authentication and offers a number of settings and complexity that do not exist in standard machine translation services and so none of the existing modules can easily be adapted.

I am also involved in the company developing Sprawk and we are committed to maintaining the module and developing a 7.x version also.
The module (and an optional statistics/debugging module) have been tested with Coder and have code documentation and an installation guide all ready to go.

I update uploaded the code to the sandbox at http://drupal.org/sandbox/niccottrell/1087762

---

From the INSTALL.txt:

What is the Sprawk module?
----------------------------

The Sprawk Module is designed to make translation of your site content and menus very easy. Rather than "polluting" your localization table with user-gernated content, the Sprawk module catches and sends your HTML content to an external server for translation. Unlike Google translate, Sprawk records all translations requests, automatically identifying important strings missing translations and queueing them up so that you can translate them yourself or hire a freelance translator. The Sprawk module caches all requests locally to speed up the response times. This module requires an account on sprawk.com which is free for non-profit web sites.

Requirements
------------

- Drupal 6.x
- PHP 5.x (This module uses PHP5 JSON functionality)
- "Locale and "Content translation" modules enabled
- Apache web server with ProxyPass enabled

We recommend that you have the jQuery update module installed.

Comments

niccottrell’s picture

niccottrell commented

Also, see my old CVS application node: http://drupal.org/node/974828

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Active » Needs review
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Needs work

Please put the current code in your Git sandbox. There seems to only be a .info file there currently, so I can't review that.

niccottrell’s picture

niccottrell commented
Status: Needs work » Needs review

Sorry - I'm new to git and didn't push the changes correctly. I believe all the files are now in the sandbox.

ccardea’s picture

ccardea commented
Component: new project application » module
Status: Needs review » Needs work

Hello niccottrell,

I'm sorry that you had to wait so long for someone to look at your project. We have a serious shortage of reviewers and I invite you to contribute to the code review process. Please visit http://groups.drupal.org/code-review.

I completed the initial screening of your project.
Licensing: There is no non-GPL code in the repository. I noticed some images. Can they be GPL licensed?
Module duplication: Reducing module duplication is an important goal of Drupal.org. I don't doubt that you are the only one offering the sprawk service. You did mention the differences between your project and Google translate. Could you explain why someone would want to use your project as opposed to Drupal translations http://localize.drupal.org/translate.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Closed (won't fix)

Closing due to inactivity, feel free to re-open if this was a mistake.

niccottrell’s picture

niccottrell commented
Status: Closed (won't fix) » Needs review

After upgrading this module to D7 for a few of our clients we'd like again to make it a public module. I've included the D7 code in git and updated the D6 code also, making 6x-1.x and 7x-1.x branches in git. As per previous comments, I have removed the images (since they weren't really needed anyway, and have run the code through Coder to check for errors and formatting stuff.

I set up git on the production server and now our production Drupal sies are running off a clone of the 7x-1.x code, so I'm sure it's pretty stable.

The code is basically feature complete, as this module is really just a wrapper for an API call to a web service, so I think it will be just minor changes in the future, but this is a key part of expanding our business so this module is guaranteed to be maintained and we'll push anything new we add for our customers.

patrickd’s picture

patrickd commented
Status: Needs review » Needs work

Welcome back!

Please fix at least these isses before switching back to needs review:

  • README.txt is missing, see the guidelines for in-project documentation.
  • Please take a moment to make your project page follow tips for a great project page.
  • Remove "version" from the info file, it will be added by drupal.org packaging automatically.
  • ./sprawk.module: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
    function ct($string, $topic = '', $args = 0) {
  • Remove all old CVS $Id tags, they are not needed anymore.
    sprawk.info:1:; $Id$
sprawk.install:2:// $Id$
sprawk.module:2:// $Id$
sprawk_stats.info:1:; $Id$
sprawk_stats.module:2:// $Id$

while waiting for an in-depth review you can have a look at the further issues detected by automated tools:
7.x-1.x Branch: http://ventral.org/pareview/httpgitdrupalorgsandboxniccottrell1087762git...
6.x-1.x Branch: http://ventral.org/pareview/httpgitdrupalorgsandboxniccottrell1087762git...

We do really need more hands in the application queue and highly recommend to get a review bonus so we will(/can) come back to your application sooner.

regards

niccottrell’s picture

niccottrell commented

Thanks Patrick! It's great to be back :)

About the automated review links - will they automatically updated as I push fixes? Or do I have to trigger a re-process somehow?

patrickd’s picture

patrickd commented

you got to submit a retest by clicking on the repeat review tab

// never mind ;)

niccottrell’s picture

niccottrell commented

Doh! Will try not to bother you with such easy questions....

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.