I was wondering whether 'node locking' is on the roadmap for workbench (node locking as in: preventing two or more users from editing the same node at the same time, since this causes at least one of those users to be very unhappy when they're unable to save their changes).

We're currently using Content locking on our D6 site (http://drupal.org/project/content_lock), which has been working great for our needs. When one user starts editing a node, content_locking.module makes it impossible for other users to edit it. When the original editor is finished editing, it releases this 'node lock', allowing other users to edit the node. I have found this functionality saves our content editors a lot of headaches & frustrations, since no one loses their changes anymore.

Would you consider adding something like this to workbench?

Comments

Taxoman’s picture

Taxoman commented

+1 Locking would be a useful addition to this module suite.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

The test would be "does Content Locking module work as is, cleanly within the WB interface?" We're not trying to duplicate modules...

/me goes to do some research and finds #1002788: Drupal7 port which is disappointing.

Do we have a Feature List?

brunodbo’s picture

brunodbo
he/him
commented

Seems the content_locking maintainers might be interested in doing a straight port to D7 first (see http://drupal.org/node/1002788#comment-4204896. I suggest we see how that port will work with WB, and then take it from there?

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

First steps here would be trying Coder upgrade on Content Locking.

stevector’s picture

stevector
he/him
commented
Status: Active » Postponed (maintainer needs more info)

Assuming that content_lock gets ported, what does Workbench need to do? It seems like if one editor clicked on a locked node they would just get an access denied.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

We just need to ensure that it plays nice with our UX.

Taxoman’s picture

Taxoman commented

the content_lock module is now in version 7.x-1.1, what is needed for Workbench to play nicely with it?
(http://drupal.org/node/1002788 was fixed on June 8th, in time for the current 1.1 release)

Taxoman’s picture

Taxoman commented
Status: Postponed (maintainer needs more info) » Active
agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

Taking a look.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Active » Closed (fixed)

The module works fine. Two caveats:

1) #927356: When reverting a node to a prior revision, users' locks are disrespected needs work. Revision moderation should probably be locked during editing.

2) Some of the text strings need cleanup. The English is choppy. Those should be addressed in a new issue.

Note that editing any revision locks the node, which is probably ok.