Display change markup in revisions.

Can you describe in more detail (or with images) what this feature entails. There is not enough detail here.

Perhaps this was the comment about providing access to a diff view for editors? If it isn't, I'm not sure, either.

I would start with just testing that Diff works cleanly within the Workbench framework.

http://drupal.org/project/diff has a beta for D7.

Removed a post here that was just wrong. Better testing supported the problem my own error.

So this is my first patch ever-ever, but Drupalcon Chicago put the fire in my belly.

This patch seems to make workbench_moderation play nicely with diff when moderation for the node type is disabled. Further testing would be appreciated, obviously.

That previous patch might have been premature. It is still relevant because it makes workbench_moderation play nicely with diff when moderation for the node type is disabled, which was a problem before. Getting diff involved when moderation is also involved is a bit more complicated, but I'm going to keep exploring it.

I'm starting to get a better handle on how this module is doing it's job. I've been editing my replies here quite a bit since I'm finding out that my information is incomplete or wrong quite often. As I better understand what's going on, my contributions here will improve. :)

The other key here is that we want proper hooks, not module-specific exceptions. So the if module_exists() approach should be avoided if possible.

I guess I sort of suspected that but had seen it done in other modules so I wondered if it might be a "We support using our module with other_module!" In a previous edit of my comment I had said that it didn't make sense to do it this way because it ignored that someone could use some other module to further manage revisions beyond core and diff.

I'm going to submit what I've found as a new issue, then, and work on figuring out the right way to solve it as a good learning experience. :D

Edit: Someone else already added the bug here:

#1089834: Call to undefined function node_revision_overview()

#1083720: Incorporate Diff to Compare Revisions