I have a number of roles added through the features module and none of them will show from the admin/settings/filters/defaults page. It seems as though this module doesn't pick them up, although all the other places within the site is aware of the roles existence.

Comments

dragonwize’s picture

dragonwize commented
Status: Active » Closed (duplicate)

#616496: Features integration

nicholas.alipaz’s picture

nicholas.alipaz commented
Status: Closed (duplicate) » Active

Actually this is not a duplicate, I don't think you understand the issue.

The roles appear in the {role} table in the database and they were autocreated via a feature. However they do not get listed in the list of roles at admin/settings/filters/defaults. If I create a role manually it shows up. But creating it via feautures simply does not work.

It seems the issue is around line 110 of better_formats_default.admin.inc where we have:

  // get data from db
  $sql = "SELECT bf.*, role.name
          FROM {better_formats_defaults} AS bf
          INNER JOIN {role} AS role
          ON bf.rid = role.rid
          WHERE bf.type IN ('$types')
          ORDER BY bf.type_weight DESC, bf.weight, role.rid";

When the role is created via features it won't have an entry in {better_formats_default} so there is nothing to do an INNER JOIN against and it won't be added to the object that is used to output the list of roles on admin/settings/filters/defaults.

Looking at my tables in mysql I can see that {better_formats_default} is indeed missing 2 roles that were imported via features.

dragonwize’s picture

dragonwize commented
Status: Active » Closed (duplicate)

It is a duplicate.

Features, like many other modules, creates roles by sticking them straight into the database. This is because D6 does not have an API for roles. By doing so it bypasses BF's knowledge of the the role that is hooked into the form api because there is no roles api.

There has been code committed to help modules around this for the time being. The features integration patch should be taking care of using this code for the features module.

nicholas.alipaz’s picture

nicholas.alipaz commented
Status: Closed (duplicate) » Active

OK, I see what you are explaining. Thanks for describing the issue.

nicholas.alipaz’s picture

nicholas.alipaz commented
Status: Active » Closed (duplicate)

oops, sorry firefox cached that form

paskainos’s picture

paskainos commented

subscribing