Needs review
Project:
Marinelli
Version:
7.x-3.0-beta11
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
11 Mar 2011 at 04:59 UTC
Updated:
25 Oct 2017 at 12:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
OneSharpeGuy commentedThis is an ugly hack that hiding of a banner on specific pages. I modified sites/all/themes/marinelli/logics/banner.inc to allow for banner exclusion. I'm no PHP guru, but it works for my purposes. If the path starts with an exclamation point, the banner will not show on path matching what ever follows the (!), ie
enter node/14 for banner visibility and the banner will show on any path except for node/14
Comment #2
mavimo commentedPatch into attachment
Comment #3
mavimo commentedComment #4
dsdart commentedThis is the first patch I've ever applied to Drupal, so maybe I missed something, but I am getting an error now instead of images:
Notice: Undefined index: image_visibility_invert in marinelli_show_banners() (line 109 of ...\sites\all\themes\marinelli\logics\banners.inc).
I changed that line to the following to get rid of the error but not sure how to actually fix the patch:
if (isset($banner['image_visibility_invert']) && !$banner['image_visibility_invert']) {
Comment #5
mavimo commentedThis is the new patch for marinelli 7.x-3.0-beta11 let us know if you have some problem n apply this patch to last version of marinelli.
Comment #6
MochaMan commentedI would like to try this patch. I have very little understanding of git. Is there a tool that makes the application of a patch easy?
Comment #7
mavimo commented@MochaMan: I try to run this command (on linux/unix shell) and all work fine.
Clone marinelli repository
git clone --branch 7.x-3.x http://git.drupal.org/project/marinelli.gitGo into the folder
cd marinelliSelect current release (you can see all tag by using git tag -l command):
git checkout 7.x-3.0-beta11Download patch:
wget http://drupal.org/files/issues/invert-visibility-settings-1088650-2.diffApply patch
git apply -v invert-visibility-settings-1088650-2.diffLet us know if you have some other question and give some feedback about this feature ;)
Comment #8
Lioz commentedpushed in the next release
Comment #10
paweld commentedI applied the patch. Something is wrong with it. Now, when I load my homepage I get an error page: "Fatal error: Call to undefined function marinelli_show_banners() in [...] \sites\all\themes\marinelli\template.php on line 126"
Comment #11
paweld commentedComment #12
Victoria9 commentedIs there a module I can download this doesn't work with Godaddy as the host instead of a localhost
Comment #13
manoloka commentedHi there,
How is this feature request going? Is there any working patch?
I think it'd be expected some behaviour just like what blocks visibility does.
Comment #14
scsmith commentedCan anyone confirm the patch in #5 works with 7.x-3.0-beta12. I tried it, but doesn't seem to function properly....I admit I might have done something wrong, but before I messed up my site I thought I'd see if anyone has it working.
To clarify, it DOES work, but I seem to lose the ability to "rotate" images....for example 2 banners on excluding /blog - only one image shows, doesn't rotate as it used it.
I hope this becomes a FEATURE in the next release because without it, the banner system is "confusing". If I set up a banner for a specific url (i.e. blog/), it will continue to show the "" banners, unless I specifically define the banner to be on ALL pages except that one, and on a large site, that is nearly impossible!
*EDIT* - Sorry - after further testing, I can confirm it works with 7.x-3.0-beta12. it was my mistake. I had replaced the original with the patched folder and forgot to include the JS needed to make it work. Please ignore, but hope this becomes a "standard feature" in the next update!