opening an issue for upgrading to d7

CommentFileSizeAuthor
#8 duplicatemail-upgrade7-1089314-8.patch17.3 KByesct
#8 interdiff-7-8.txt806 bytesyesct
#7 interdiff-3-7.txt963 bytesyesct
#7 duplicatemail-upgrade7-1089314-7.patch17.27 KByesct
#3 duplicatemail-upgrade7-1089314-3.patch17.27 KBkerasai

Comments

geerlingguy’s picture

geerlingguy commented
Version: 6.x-1.0 » 7.x-1.x-dev

Subscribe.

pauligree’s picture

pauligree commented

subscribe

kerasai’s picture

kerasai commented
Status: Active » Needs review
StatusFileSize
new duplicatemail-upgrade7-1089314-3.patch17.27 KB

Patch upgrading master branch (assumed to be 6.x-1.x) to D7.

yesct’s picture

yesct commented

wow. thanks.
was this a refactor while upgrade, or was it needed to get things working?

I'll try it out.

kerasai’s picture

kerasai commented

Been a few days since I did it, so don't hold me to the details.

The biggest chunk of the patch is the view. Other changes were block hooks, using D7's database API, and I killed an unnecessary function.

Changed a little bit of logic:

  • Grab UIDs then load user entities in one shot, not possible in D6.
  • Separated the data gathering part from the markup generation. Still happens in the same function, but now distinct steps. A few improvements could still be made here.

Tried to stick to just the upgrade, but... Yeah, well.

yesct’s picture

yesct commented

[edit]

global block works fine, and the block for the user pages does also. :)

yesct’s picture

yesct commented
StatusFileSize
new duplicatemail-upgrade7-1089314-7.patch17.27 KB
new interdiff-3-7.txt963 bytes

little cleanup of style.

yesct’s picture

yesct commented
StatusFileSize
new interdiff-7-8.txt806 bytes
new duplicatemail-upgrade7-1089314-8.patch17.3 KB

well, since splitting that line, lets do each part on its own line. (clearly a nit)

yesct’s picture

yesct commented
Status: Needs review » Fixed

pushed. 4c36e5390c

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.