Module administration page is not using the standard Drupal function system_settings_form. It should be used because is the santard Drupal way and makes easier to add new configurations to the module.

Comments

stewart.adam’s picture

Status: Active » Closed (won't fix)

This is true, however some of the newer additions to the settings page require preprocessing so it's easiest to simply not change this and perform the preprocessing of form values in the submit handler before we do variable_set(). Otherwise we'd have to inject a submit handler for the particular form elements that require preprocessing via the form's #submit index.