The messages from Workbench Access and Workbench Moderation are useful, but intrusive and a misuse of the message system.
Instead we want a Workbench block that admins can place where they wish. The block should define a render array standard that other modules may add messages to.
-- workbench_block_view()
-- hook_workbench_block_view()
-- hook_workbench_block_view_alter()
In later iterations, we may need configure options as well.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 1089474.info-block.patch | 2.56 KB | agentrickard |
| #7 | 1089474-workbecnh-access-info.patch | 2.18 KB | agentrickard |
| #6 | Screen shot 2011-03-14 at 2.11.02 PM.png | 27.96 KB | agentrickard |
| #3 | 1089474-workbecnh-access-info.patch | 2.37 KB | agentrickard |
| #2 | 1089474.info-block.patch | 1.81 KB | agentrickard |
Comments
Comment #1
agentrickardThese hooks are already provided by core. I just documented them.
Comment #2
agentrickardWrong patch!
Comment #3
agentrickardAnd a related patch to move the Workbench Access messages.
Comment #4
yoroy commentedConsider positioning and making it look similar to how the issue and handbook meta data for entries work here:
and
An important aspect of both these designs is that the info blocks are shown below the title, which makes it clear that this is info about that particular content item, not the "whole page".
Comment #5
agentrickardNice. I like the second example a lot. I think we can do that by wrapping the block in a div and default placing it in the top of the 'content' area.
Comment #6
agentrickardLike so?
Comment #7
agentrickardProper patch for WB and WA.
Comment #8
yoroy commentedI would definately recommend to go ahead with this. Tweakage of how all the bits that go in there can still happen afterwards.
Comment #9
agentrickardReady for commit.
Comment #10
agentrickard@becw
This has been committed. Can you add / move the Workbench Moderation bits here, too?
Comment #11
brunodboLooks great. Only thing I'm wondering about is the actual text in the block. Eg. for certain site users, 'Workbench access: ...' might not mean much. But I guess since the whole text is run trough t(), site builders can put whatever they want there through the translation interface?
Comment #12
agentrickardWe used 'Editorial section' for a while, but @caroltron asked for it to be made explicitly 'Workbench access' during an earlier dev cycle.
Comment #13
brunodboI'm thinking that the needs for which text to put there may depend heavily on which site WB is used. Eg: on a news site it may be 'Editorial section', while on a collaborative blog it may be 'Blog'. Could we perhaps make it configurable/overrideable (maybe it is already)?
Comment #14
agentrickardIt could be a configuration option, sure. You care to open a new issue for that?
Comment #15
brunodboIt's here => #1139568: Make Workbench Moderation messages configurable
Comment #16
stevectorI think everything needed here can be covered in #1139568: Make Workbench Moderation messages configurable