The attached patch upgrades me 4.7-1.0 (v1.3) to Drupal 5. I'm running it now on 5.0-rc2, with no problems so far.

CommentFileSizeAuthor
#4 me_47_50_2.patch2.42 KBewhipple
me47-50.patch2.4 KBewhipple

Comments

ewhipple’s picture

ewhipple commented
Priority: Critical » Normal

Sorry, wrong priority.

ewhipple’s picture

ewhipple commented
Status: Needs review » Needs work

Sorry again. I've just found out I'm making patches all wrong way. I'll upload a corrected one soon.

ahoeben’s picture

ahoeben commented

Thanks for the effort. I'll try to set up a 5.x branch and release over the coming week.

PS; so you find it useful then?

ewhipple’s picture

ewhipple commented
Status: Needs work » Needs review
StatusFileSize
new me_47_50_2.patch2.42 KB

Hokay, I'm completely bald now. I pulled out all my hair trying to get TortoiseCVS and CygWin to play nice together. I got it to work, and now I'm going to go solve the Middle East peace problem.

The attached patch is pretty close to identical to the first one, but I made it against the CVS version rather than an installed tarball. I guess that doesn't matter much for this module, but at least now I know how to make it all work for the next time.

I do indeed find this module useful. I'm setting up an intranet portal at the office, and I have to get the menus as simple and pretty as possible, to minimize new-user intimidation. Unfortunately, several modules insert locked menu items that interfere with my grand designs. The me module lets me chop those all out and replace them with something I can reconfigure however I need.

Perhaps we should try to turn this into an API. If it were in core, every module that wanted to could easily create a configurable "me" menu item. If it were done right, I bet that a total of more than twice the code required to implement the API would be eliminated from the core and commonly-used contrib modules.

What do you think: interested in giving it a try?

ahoeben’s picture

ahoeben commented
Status: Needs review » Fixed

Applied with one difference: access control is handed over to the destination page (where 'me' is replced with $user->uid). That page could be anything (or not even exist), so there's no way of knowing what the access control should be.

A 5.x branch is now available, marking as fixed. Feel free to continue the API discussion here, or make a new issue for it.

ewhipple’s picture

ewhipple commented
Status: Fixed » Closed (fixed)

I think the change in access control makes sense.

I have a couple of API-related ideas. I'll open a new issue when I have my thoughts better organized.

Thanks for producing this module; it's definitely useful.