This file is the patch to update the taxonomy_menu 4.7 to version 5.0
.info file included in the next post.

CommentFileSizeAuthor
#32 taxonomy_menu.zip_.txt20.76 KBBevan
#24 taxonomy_menu.module_3.patch4.57 KBRobRoy
#23 taxonomy_menu.module_2.patch4.57 KBRobRoy
#21 taxonomy_menu.module_1.patch4.8 KBRobRoy
#7 taxonomy_menu.info_0.txt149 bytesdrewish
#6 taxonomy_menu.info.txt125 bytesdrewish
#5 taxonomy_menu_5.patch4.84 KBdrewish
#4 taxonomy_menu_4.patch2.22 KBcsevb10
#2 taxonomy_menu_0.zip241 bytescsevb10
#1 taxonomy_menu.info124 bytescsevb10
taxonomy_menu_3.patch2.19 KBcsevb10

Comments

csevb10’s picture

csevb10 commented
StatusFileSize
new taxonomy_menu.info124 bytes

.info for Drupal 5 Port

csevb10’s picture

csevb10 commented
StatusFileSize
new taxonomy_menu_0.zip241 bytes

Since Drupal seems to block .info files, here's .info as a zip

RobRoy’s picture

RobRoy commented
Status: Reviewed & tested by the community » Needs work

It's best to not mark your own patches RTBC.

- 'callback arguments' takes an array as a value, not a string
- Remove that hook_settings Doxygen as that is not a hook anymore, just say it's the settings menu callback.

csevb10’s picture

csevb10 commented
StatusFileSize
new taxonomy_menu_4.patch2.22 KB

Sorry, Rob. Still new to the whole contributing back to Drupal aspect.
- fixed the comment for the settings function
- modified the 'callback_arguments' to take an array.

drewish’s picture

drewish commented
StatusFileSize
new taxonomy_menu_5.patch4.84 KB

i've updated csevb10's patch. it uses more of the new functions offered by 5.0.

drewish’s picture

drewish commented
Version: 4.7.x-1.x-dev » master
StatusFileSize
new taxonomy_menu.info.txt125 bytes

better version. i've also updated the .info file to use the name tag for the version

drewish’s picture

drewish commented
StatusFileSize
new taxonomy_menu.info_0.txt149 bytes

the .info file should have a taxonomy dependency

csevb10’s picture

csevb10 commented

Thanks drewish, a few of those I'm still completely unfamiliar with, so I'm glad someone improved upon what I did!

drewish’s picture

drewish commented
Status: Needs work » Needs review

never updated the status.

csevb10, were you actually able to test my patch?

csevb10’s picture

csevb10 commented
Status: Needs review » Needs work

Also, drewish, shouldn't the revision be "$Name$" instead of "$Name: $" (as discussed here: http://drupal.org/node/101009)?
I'm interested to know because I just started using $Name$

csevb10’s picture

csevb10 commented

As far as I can tell, it worked. I modified my taxonomy_menu module to allow placing the module into more than 1 menu, so I couldn't patch the file directly. I ported over the changes that you added, though, and wasn't able to find any issues. Can anyone else verify?

drewish’s picture

drewish commented

I'm pretty sure it doesn't matter, I use $Id:$ and CVS replaces that just fine and I've used $Name:$ in other modules.

drewish’s picture

drewish commented
Status: Needs work » Needs review

looks like we cross posted and unset the status...

mandclu’s picture

mandclu commented

FWIW, I just tried to use the latest patch and .info files from this thread, but my install of the release version of 5.0 didn't list it in the modules available to be enabled. Thoughts?

drewish’s picture

drewish commented

surge_martin, silly question but you renamed the .info file from comment #7 to taxonomy_menu.info right? and you applied the patch? to the HEAD version of the module?

mandclu’s picture

mandclu commented

Correct on all counts. I did notice that when I ran the patch, I got a message that it was installing the patch, but not necessarily that it had successfully completed. From what I could see, it had changes everything but the info line at the start. Could that be the issue?

Could someone try uploading the patched module to see if for some reason my patching is at fault?

mandclu’s picture

mandclu commented
Title: Port to Drupal 5.0 » my bad

Whoops, I'm testing this on an OS X install, and the OS still had a .txt extension on the info file. With that fixed, the module appears and functions fine.

sepeck’s picture

sepeck commented
Title: my bad » update to 5.0

resetting title

mandclu’s picture

mandclu commented

This version seems to break the image galleries, they appear as standard taxonomy listings, it appears to happen because the menu urls are taken over by taxonomy_menu. Anyone else encounter this?

drewish’s picture

drewish commented

surge_martin, you should be able to uncheck that taxonomy from on the setings page and keep it out of the menus.

RobRoy’s picture

RobRoy commented
StatusFileSize
new taxonomy_menu.module_1.patch4.8 KB

Fixed up some more stuff. The .info file above is good, here is an update patch for the .module.

drewish’s picture

drewish commented

RobRoy, you'd re-added the settings link on the help page that I dropped. Do we really need that? The link is added by default at the bottom of the page...

RobRoy’s picture

RobRoy commented
StatusFileSize
new taxonomy_menu.module_2.patch4.57 KB

Ah, I didn't check that page. So that line can be taken out. My bad.

This should apply with offset.

RobRoy’s picture

RobRoy commented
StatusFileSize
new taxonomy_menu.module_3.patch4.57 KB

Ah, I didn't check that page. So that line can be taken out. My bad.

This should apply with offset.

vjordan’s picture

vjordan commented

I can't apply the patch from RobRoy. (The patches from csevb10 apply fine.)

I'm using unixutils on windows patch version 2.5.9. I've converted EOLs using unix2dos and it's rejecting with the following error:

Patching file `taxonomy_menu.module' using Plan A...
patch: **** malformed patch at line 27: @@ -31,6 +29,16 @@ function taxonomy_menu_menu($may_cache)

Any advice how I can get around this?

chazoopa’s picture

chazoopa commented

It's all gone quiet on this thread. Can someone post an update on where the upgrade to V5 has reached. It would be nice to know if the contributors feel this is at a point we can test it.

Thanks

drewish’s picture

drewish commented

it's gone silent because it's working ;) give robroy's patch #21 a try.

dinnouti’s picture

dinnouti commented

please can someone publish the patched version here?
thx

Bevan’s picture

Bevan commented

pity please? ;)

RobRoy’s picture

RobRoy commented
Status: Needs review » Reviewed & tested by the community

If it's working then this is RTBC and should be committed to the module. Is the committer around?

drewish’s picture

drewish commented

i don't think there's a committer to be found but it's definitely RTBC

Bevan’s picture

Bevan commented
StatusFileSize
new taxonomy_menu.zip_.txt20.76 KB

using patch from comment #21 and .info file from comment #7 I put together this. and zipped it up -- probably someone will find it a timesaver.

I couldn't apply patches from comments #22 or #23, neither before nor after applying patch from comment #21.

I got the same error on line 27 every time. (like from comment #25)

Briefly tested, and seems fine.

RobRoy’s picture

RobRoy commented
Status: Reviewed & tested by the community » Fixed

I just added myself to CVS access for this module because I was sick of waiting. I've branched to DRUPAL-5 and created a 5.x-1.x-dev development release. Please check in a few hours. Thanks everybody for the hard work.

Bevan’s picture

Bevan commented

Searching for a solution led me to "Using pathauto with menu paths": http://drupal.org/node/41450

It seems it was never committed to 4.7 branch, and therefore didn't make it into these patches -- which is a real shame. That's what we have CVS for -- right? Any thoughts or volunteers?

Bevan’s picture

Bevan commented

I'm having a go at adding Lowell's hack to this port: http://drupal.org/node/121513

srcerer’s picture

srcerer commented

so i am curious to know if there are any planned updates to sort out how taxonomy_menu and pathauto work together (see http://drupal.org/node/41476). i can't just apply their changes as i am using 5.1.

thanks for the update!

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)
johnv’s picture

johnv
Primary language Dutch
commented
Version: master » 5.x-1.x-dev

Reassigning, to not show anymore in 7.x issues.