Currently, the nodejs_notify module relates to two separable functions: (1) it contains the code for displaying notifications to the client using jGrowl alerts, and (2) it provides actions that can be used by Drupal's trigger module.

I think these functions should be separated into two modules, as these two functions are not mutually dependent, and the UI notifications can be used by the nodejs_subscribe module (or other custom implementations).

Comments

Anonymous’s picture

Anonymous (not verified) commented

yep, sounds like a good idea to me.

Anonymous’s picture

Anonymous (not verified) commented

i'm going to be busy with $$$$ work for the next few months, so don't wait for me to do this.

arithmetric’s picture

arithmetric commented
Status: Active » Fixed

I've made this change to separate the Actions-related code in nodejs_notify as a separate nodejs_actions module. The change is in commit ad00903.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit ad00903 on 6.x-1.x, 7.x-1.x, drupalconlondon, auth-refactor, 8.x-1.x, 8.x-1.x-head by arithmetric: 
    #1089752: Separating nodejs_notify Actions-related code into separate...