The clickLink implementation throws an exception in PHP 5.3 because the $url_target variable is not always defined.
If it isn't set, I'm not sure if it is best to leave it blank, or have some text or what. Here is a patch that makes it say 'Not Found' in place of the URL in the assertion.
Noticed over here: http://drupal.org/node/647964#comment-3918426 There are 3 exceptions in this test run because it is trying to click a link that apparently doesn't exist.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | undefined-variable-url_target-8.patch | 1.13 KB | freblasty |
| #6 | undefined-variable-url_target-1089792-5.patch | 744 bytes | kid_icarus |
| #1 | undefined-variable-url_target-1089792-1.patch | 1 KB | loganfsmyth |
Comments
Comment #1
loganfsmyth commentedHere's my patch.
Comment #2
naxoc commentedThis is still an issue in D8. The
$url_targetvariable never gets set if there is something wrong with the link.Comment #3
xjmTagging for backport.
Comment #4
xjmI think if the link is not found, there should probably be an assertion failure explicitly stating it was not found.
Comment #5
xjmComment #6
kid_icarus commentedIs it still considered backporting if you go from 7.x to 8.x?
As far as a test goes, I was working on one over at #1452896: PHP notice in clickLink if link does not exist but I was having trouble with the logic. I'll give it another shot but, perhaps this patch will give me more to work with :)
Comment #7
freblasty commentedPicking this up for the office hours sprint.
Comment #8
freblasty commentedWhen the assertion fails it will explicitly state that the link was not found instead of the $url_target being set to 'Not found'.
Comment #9
webchick#1452896: PHP notice in clickLink if link does not exist is technically a duplicate of this one, but it has a bit more discussion + an automated test, so unfortunately I'm closing this one. So sorry! Please feel free to head over there if you're keen to continue working on this. :)