We should use Pressflow

Assuming there's a good reliable way to fetch pressflow, I'm okay with that. However, last I heard, pressflow lives in bzr, and I'm less psyched about having a dependency on both Git and bzr. But, if it's easy to get tarballs for fixed versions and just reference those directly, I'm happy.

Thanks!
-Derek

An alternative here is to get a copy of vanilla Drupal 6 and apply the 20 or so patches that turn it into Pressflow. That would be a really easy addition to the Drush make files.

Patch in #4 is good.

@cweagans: What about the simpletest failures @naxoc mentioned in #4?

Re: #4, Pressflow ships with E_NOTICE turned on (or, rather, it doesn't explicitly strip it out, as D6 core does). So that might be at least part of the problem.

When I run Project issue tests with Pressflow I'm getting a bunch of exceptions like this:

Table 'mydrupalorg.simpletest20508autoload_registry' doesn't exist query: _autoload_registry_check_code /* a : _autoload_registry_check_code */ SELECT filename FROM simpletest20508autoload_registry WHERE name = 'views_plugin_display_default' AND type = 'class'	User warning	database.mysqli.inc	147	_db_query()	
Table 'mydrupalorg.simpletest20508autoload_registry' doesn't exist query: _autoload_registry_check_code /* a : _autoload_registry_check_code */ SELECT filename FROM simpletest20508autoload_registry WHERE name = 'views_plugin_display_default' AND type = 'interface'	User warning	database.mysqli.inc	147	_db_query()	
Table 'mydrupalorg.simpletest20508autoload_registry' doesn't exist query: _autoload_registry_check_code /* a : _autoload_registry_check_code */ SELECT filename FROM simpletest20508autoload_registry WHERE name = 'views_plugin_display' AND type = 'class'

And then also a few of these:

Undefined index: value	Notice	views_handler_filter.inc	431	views_handler_filter->exposed_form()	
Undefined property: stdClass::$unknown	Notice	views_handler_field.inc	459	views_handler_field->render()

Having to manually update this URL every time a new version of Pressflow comes out seems like an insane PITA. Luckily, according to https://answers.launchpad.net/pressflow/+question/115252 there is a tarball URL that will always have the latest version of Pressflow: http://files.pressflow.org/pressflow-6-current.tar.gz Yay!

One nice thing is this takes the wait time to get output on the screen from 3+ minutes to only maybe 10 seconds. w00t!

Additionally, the patch at #341140: drupal_get_filename() when database is down, does not deal with phptemplate themes is needed to even install the profile currently, so this patch includes that as well (I had to upload a -p0 version at http://drupal.org/node/341140#comment-4561870 cos apparently drush make hasn't been schooled in Git).

Here's a re-rolled version after #1148774: Automatically patch core in Drush Makefile.

Ok, the other huge issue w/ SimpleTest + Project + Pressflow is you get a flaming error when you check all of "Project" tests:

Failed opening required '' (include_path='.:/Applications/MAMP/bin/php5.3/lib/php') in /Users/abyron/Sites/mydrupalorg/modules/simpletest/simpletest.module on line 211

Through much digging that I'll spare you the details on, it appears this is caused by #627390: Filename cannot be empty if a test lasts less than 1s, which has a patch that was committed over a year ago and leaves me wondering what strange version of SimpleTest Pressflow is using. Hrm.

Someone with more drush make-fu than I is going to need to figure out how to apply the patch there to a module living in /modules instead of sites/all/modules though. :\