I found a typo in the rebuild function name. Going to try rolling a patch to fix it & call to it (my second time around on patching evar!)
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 1089908-og_statistics-typo-5.patch | 459 bytes | jeffschuler |
| #2 | docs-fix-1089908-0.patch | 1.87 KB | hongpong |
| #1 | docs-fix-1089908-1.patch | 2.63 KB | hongpong |
Comments
Comment #1
hongpong commentedAlright they're kicking us out of code sprint now, but I think this covers what needs to be done. I forgot one ref... but yeah it looks like the 2nd patch has all of em. my 2nd & 3rd patches respectively. thnx for yr review
Comment #2
hongpong commentedthis was the first one. not needed i think. (it's missing the last fix).
Comment #3
dawehnerThanks again!
Commited, added a changelog entry and added you to the commit message.
git commit --amend really rocks :)
Comment #5
jeffschulerLooks like the patch from #2 was committed instead of the complete solution in #1, because one of these typos still remains.
This patch fixes that one.
Comment #6
hefox commentedWorks and fixes the issue
Comment #7
dawehnerOh totally forgot about this patch, thanks for it!