Port to 5.x

I needed this module today... so i build a patch to use with drupal 5.x ....

Its not tested very well but it work at this moment :)

Try him end call me if some trouble happens!

cya

Hi, thank you for your patch.
I have used it today, and enabled it in the module list.
But it came out a blank page while I clicked the "default" tab in the setting page.

Are you sure your patch could support Drupal 5.0?

Sorry... i've did some mistake when o build patch...

now i am posting the correct and tested patch :)

Enjoy!

Thank you, pedrofaria.
But it still not work.
I download the 4.7 module and filter_default_0.patch, and run the patch command.
Then it generated a filter_default.patch (?), and I patch this file too.
After all these step, I found that there are more files have been added in the dictionary.

I upload this dictionary, and enable filter_default module on the admin page.
But I can't see the "default" tab while I clicked the filter setting page.
Before the patch above, it was there; now, it gone.

I am wondering if you could offer the 5.x version module rather than patch?

Thanks anyway.

Yes, as a Module would be much more useful for testing. Please :)

Tks ;)

This patch does not address the bug in http://drupal.org/node/108900. In fact, I'm not sure it is possible to resolve that bug with this module the way it is designed. Until I (or someone else) figure out whether it is possible, I'm not going to develop/promote this module any further.

Hmmmm..... i forgot to remove the oldest patch when i am building the patch...

If you just dont patch the second patch, will work...

NOW i build the last patch, tested, working fine... i swear :)

thanks and sorry for all troubles!

The issue here is not making the module work with Drupal 5; the issue is that the module is fundamentally flawed and possibly cannot be fixed given the way it works with the input filter system. See http://drupal.org/node/108900 for a discussion (starting at comment #5).

I am marking this issue 'postponed.' If/when the design issues are resolved, I will port it to Drupal 5.

As I already wrote at http://drupal.org/node/108900, I don't consider the problem described there to be a bug.

For those of us who like things as they are, a DRUPAL-5 branch with the patch applied would be a really nice thing, and probably also increase exposure to weed out further potentially exiting bugs ...

Maybe this module is not perfect as it is, but it's (IMHO a lot) better than the default without it.

Long silence with no problem reports, so I dare ask again: could we please get a DRUPAL-5 branch in cvs?
Probably with the patch to be found at http://drupal.org/node/108900#comment-194857 ?

Would you mind zipping it up and uploading it? I 'd like to take a look. (Ill also take into consideration concerns about the design flaw mentioned above)
Tks

Not my patches, but here it is, applied filter_default_1.patch and filter_default_108900.patch, and zipped it up.
You know the drill, just remove the .txt extension ...

tks

Very interested in 5.x support; I checked the referenced bug and agree that this not-perfect fix is better than core. Please release 5.x version, even a dev one.

Thanks.

The patched code (#12) worked well for me.

But, the settings did not take placed until I resubmitted the default form ( /admin/settings/filters ).

Otherwise, this has been a godsend. Thanks!

--Jason

Can someone please tell me how to apply this patch (#12) to my Drupal v5 install?

I really need this functionality but i have never done any patching.

thank you

http://drupal.org/patch/apply

Guys - you are AWESOME!

This module seems to work fine so far, but i will be keeping an eye on it. If you only knew how much easier you made my life with this module!

Works well ;) I think its ready to be commited....

Any ideas when this is likely to be packaged into a 5.x release?

Could really do with this, but I cant run patches as hosted using cPanel.

Patch locally and upload

Just recognized this issue after porting Filter Default (again) to 5.x. I totally agree with the previous posters, http://drupal.org/node/108900 may be critical to certain complex setups, but it does not apply for e.g. simple business websites. I can understand that this issue might be a downside for some people. However, this module works well for simple Drupal sites and therefore should be continued.

You might add a highly visible notice to the project description linking to the above mentioned issue.

Attached patch depends on this code clean-up issue. If that one is committed, I'll post a new one containing only changes for the 5.x port. Both patches are against HEAD.

I have created a Drupal 5 development branch. Please create new issues for any problems you have.