The module provides core system and Rules actions to send HTML e-mails, however the messages are sent directly by calling mimemail(), instead properly prepared by drupal_mail() first, so the messages would go through the alter hooks.

CommentFileSizeAuthor
#7 mimemail_1090286_02.patch2.58 KBsgabe
#2 mimemail_1090286_01.patch9.69 KBsgabe

Comments

tstackhouse’s picture

tstackhouse commented

Subscribing.

sgabe’s picture

sgabe commented
Status: Active » Needs review
StatusFileSize
new mimemail_1090286_01.patch9.69 KB

Initial patch to fix this issue, needs review and some more testing.

sgabe’s picture

sgabe commented
Title: Prepare action messages with drupal_mail() to enable alteration » Prepare action messages with drupal_mail() to allow alteration

Correcting title

itserich’s picture

itserich commented

I tried to install the patch and was unable to apply the patch. My attempt to apply the patch failed, perhaps someone could help me apply it. I have only successfully patched once before.

Also, the latest mimemail dev version is April 17 so not sure it should still apply correctly.

I already had the mimemail dev module installed. So I went to the mimemail directory and:

curl -f http://drupal.org/files/issues/mimemail_1090286_01.patch > mimemail_1090286_01.patch

then:

patch < mimemail_1090286_01.patch

The error message is:

can't find file to patch at input line 5
Perhaps you should have used the -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/includes/mimemail.rules.inc b/includes/mimemail.rules.inc
|index a0b04bd..93b8c1f 100644
|--- a/includes/mimemail.rules.inc
|+++ b/includes/mimemail.rules.inc
--------------------------

Thank you.

sgabe’s picture

sgabe commented
Status: Needs review » Fixed

The patch is committed and will be in the development snapshot soon. Please report back if you encounter any problems.

itserich’s picture

itserich commented

Thank you.

sgabe’s picture

sgabe commented
StatusFileSize
new mimemail_1090286_02.patch2.58 KB

Patch committed to remove the unnecessary settings process function and fix sending HTML message to a role action.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.